fix(1-3295): fix broken skip link #9239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the skip link wouldn't take you to the main content of the page anymore.
Also includes a few related minor semantic and a11y improvements:
main
element now only surrounds the actual main content of the page. The sidebar is nav content and shouldn't be within it. The easiest way to do this was to change the element that was previously amain
to adiv
and make the main content wrapper amain
instead.'
to search for links (I use this a lot)), making it super easy to move your focus to the main content directly. (Yes, landmark navigation should also work here, though, especially with themain
change).The implementation of UI considerations of the skip link are based on the CSS-tricks article a deep dive on skipping to content from 2021.
Here's what it looks like when you skip to content:

When it doesn't have focus, it's invisible.