chore: move to biome to align with parent project #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
reviewed
Aug 1, 2024
Dockerfile
Outdated
| @@ -30,7 +30,7 @@ RUN chown -R node:node /unleash-proxy | |||
|
|
|||
| ENTRYPOINT ["/sbin/tini", "--"] | |||
|
|
|||
| EXPOSE 4242 | |||
| EXPOSE 3000 | |||
There was a problem hiding this comment.
Oh wow, nice catch, how did that ever work?
sighphyre
approved these changes
Aug 1, 2024
chriswk
force-pushed
the
chore/biomeAsLinter
branch
2 times, most recently
from
51ebd17
to
c711d11
Compare
chriswk
force-pushed
the
chore/biomeAsLinter
branch
from
c711d11
to
0970db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use biome in unleash/unleash, I copied our configuration from the parent project and applied import sorting as well as formatting/linting using biome, all tests still run green and the docker image seems unaffected.