Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall sfx #482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Waterfall sfx #482

wants to merge 1 commit into from

Conversation

rokaso
Copy link

@rokaso rokaso commented Jul 20, 2021

Adding Watefall sfx with adjusted spacializing to feel more natural walking around it

No thread was created for this.
This will add sfx of a waterfall to it's foam prefab.
To be able to hear what is happening on screen, thus making it more alive.
Added the sound to sfx/environment and implementing it on the waterfall foam prefab as a audio listener,

Adding Watefall sfx with adjusted spacializing to feel more natural walking around it
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2021

CLA assistant check
All committers have signed the CLA.

@ciro-unity ciro-unity added the enhancement New feature or request label Jul 26, 2021
@amel-unity amel-unity self-assigned this Aug 9, 2021
@ciro-unity ciro-unity assigned ciro-unity and unassigned amel-unity Sep 5, 2021
@ciro-unity
Copy link
Contributor

Hey @rokaso, thanks for the SFX. Can I ask you for 2 things?

  • First, it would be great if you just send the audio file, as right now the changes in the prefab and ProBuilder data are creating a conflict. If it's easier, you might close this PR and create a new one.
  • Did you make the SFX? Can you provide the running stream part and the falling water part as separate? Since we have a scene where the character moves close to the water and multiple waterfalls, it would be nice to be able to separate the 2 SFX and position them farther away.

Thank you!

@ciro-unity ciro-unity added the ? Action required: missing information, question to answer, or CLA not signed label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? Action required: missing information, question to answer, or CLA not signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants