Event Aggregator proposal #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A limited change to demonstrate events published from Input. EventAggregator was applied to Protagonist. UnityEventBus was applied to camera events.
|
|
| public class Protagonist : MonoBehaviour | ||
| public class Protagonist : MonoBehaviour, | ||
| IHandle<AttackEvent>, | ||
| IHandle<JumpEvent>, |
There was a problem hiding this comment.
The naming here is gorgeous!
|
Assets\ScriptableObjects\Input\InputReader.asset is missing the assignment of EventAgregator and EventBus. |
|
Cool ideas. I've written some feedback on the forums! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A limited change to demonstrate events published from Input.
An EventAggregator was created and a SO to hold the instance so that it can be shared within the project.
The publishers were located in Inputs and for limited changes only those events that were applicable to Protagonist was applied.
Also there is a UnityEventBus that was created to avoid reflection and link to UnityActions that could be exposed to the inspector or an existing function can be used. The later was demonstrated in the camera manager.