-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ChaCha20 crypto transport #55
base: main
Are you sure you want to change the base?
Conversation
Two things not yet finished:
Both these things should be fixed before we merge this. But it's a good starting point for crypto. I will get to this once I have time. Just thought it still might be useful as a PR in the meantime. |
Counter synchronization is now implemeneted. You can have anywhere between 64-128 blocks of loss or reordering before things break. This could be massively improved by using some of the first header byte to store a slightly larger counter (just a few bits would make a huge difference). This however requires custom int rollover so will have to be future developments. A cert handler is also implemented and required when using signed handshakes. |
Had to retarget this at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks all good. We shuffled some stuff around in the repo and file paths for transports now use com.community.netcode instead of com.mlapi.contrib. etc. Could you adjust that?
|
No description provided.