-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Update Gym to Gymnasium #6166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update Gym to Gymnasium #6166
Conversation
I looked at the code. Everything is ok to release, I don't understand why they didn't approve it... |
Not sure. I also have code to update PettingZoo to a version working with Gymnasium here but given that it includes other fixes to Zoo and the silence on this PR, I haven't tried integrating in here. |
@maryamziaa @alexander-suvorov I decided to add the anticipated pettingzoo changes to this PR since it hasn't gotten much attention. This should resolve any issues that might directly result from use of this code. In addition, there are also issues with uint8 visuals but I have withheld those here as they are a really more of a separate issue. Please let me know if there's anything I can do to help move this issue forward. I have been using this code across single vector, multi vector, and pettingzoo environments without issue for nearly a year now without issue (aside from uint8 visuals which would need a separate PR). |
Hey, thanks for putting this PR together! Unfortunately, we haven’t been able to review PRs or community contributions lately since ML-Agents was in maintenance mode. The good news is we’ve started ramping back up and getting things back up to speed again. Alex and I will take a look at your PR soon, but it might not be right away, sorry! But fear not, it’s definitely on my list. |
@maryamziaa Thanks for the update. Glad to hear! The lack of gymnasium support in the official pip package has been a major roadblock in use since git branches as dependencies are not allowed in published pip packages. |
Proposed change(s)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
There is 1 open PR and 4 issues related to this addition:
Types of change(s)
Checklist
Other comments