Conversation
There was a problem hiding this comment.
The review identified several points for consideration. Key highlights include a potential dependency version regression and the need to verify logic handling for the transition to an asynchronous Search API. Minor improvements for changelog placement and formatting were also suggested.
🤖 Helpful? 👍/👎
CHANGELOG.md
Outdated
| ## [5.1.6] - 2026-03-30 | ||
| ### Changed | ||
| - Replaced obsolete `EntityId.GetRawData()` with `EntityId.ToULong(EntityId)` (warning CS0618). | ||
| - Replaced obsolete `SearchService.GetItems` with `SearchService.Request`(warning CS0618). |
There was a problem hiding this comment.
Have you considered the implications of replacing SearchService.GetItems with SearchService.Request? The obsolete GetItems method was synchronous and returned a list of items, while SearchService.Request (introduced in Unity 6) is fundamentally asynchronous. If the calling code was not updated to handle the asynchronous result, it may now behave incorrectly by proceeding with an empty or incomplete list of results.
🤖 Helpful? 👍/👎
There was a problem hiding this comment.
We are using SearchFlags.Synchronous search flag in this change so should be good.
That said, your comment made me realized we were not actually testing the GetSceneReferences function for 2021.2+ 😬
So updated a test to help with that.
Co-authored-by: u-pr[bot] <205906871+u-pr[bot]@users.noreply.github.com>
Purpose of this PR
Ticket/Jira #: UUM-137284
FindObjectsSortMode.Noneusage in testTesting
Functional Testing status:
Performance Testing status:
Documentation & UX Writing
Additional information
Note to reviewers:
Reminder: