Skip to content

[UUM-137284] Fix another warning + upgrade#751

Open
mfe wants to merge 7 commits intomainfrom
UUM-137284_warnings
Open

[UUM-137284] Fix another warning + upgrade#751
mfe wants to merge 7 commits intomainfrom
UUM-137284_warnings

Conversation

@mfe
Copy link
Copy Markdown
Collaborator

@mfe mfe commented Mar 26, 2026

Purpose of this PR

Ticket/Jira #: UUM-137284

  • Upgrade to 5.1.6 to prep release
  • Remove Obsolete FindObjectsSortMode.None usage in test

Testing

Functional Testing status:

Performance Testing status:

Documentation & UX Writing

User facing text to review Details
User interface
Public API docs
Changelog
Documentation halo effect Jira link
User manual
Other docs

Additional information

Note to reviewers:

Reminder:

@mfe mfe changed the title warnings Fix another warning + upgrade Mar 26, 2026
Copy link
Copy Markdown

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good
The review identified several points for consideration. Key highlights include a potential dependency version regression and the need to verify logic handling for the transition to an asynchronous Search API. Minor improvements for changelog placement and formatting were also suggested.

🤖 Helpful? 👍/👎

CHANGELOG.md Outdated
## [5.1.6] - 2026-03-30
### Changed
- Replaced obsolete `EntityId.GetRawData()` with `EntityId.ToULong(EntityId)` (warning CS0618).
- Replaced obsolete `SearchService.GetItems` with `SearchService.Request`(warning CS0618).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
Have you considered the implications of replacing SearchService.GetItems with SearchService.Request? The obsolete GetItems method was synchronous and returned a list of items, while SearchService.Request (introduced in Unity 6) is fundamentally asynchronous. If the calling code was not updated to handle the asynchronous result, it may now behave incorrectly by proceeding with an empty or incomplete list of results.

🤖 Helpful? 👍/👎

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using SearchFlags.Synchronous search flag in this change so should be good.
That said, your comment made me realized we were not actually testing the GetSceneReferences function for 2021.2+ 😬

So updated a test to help with that.

@mfe mfe changed the title Fix another warning + upgrade [UUM-137284] Fix another warning + upgrade Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant