Update RenderingPlugin.cpp: postponed initialization to OnRenderEvent() to avoid invalid GL Context handle #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this minor change, the example project becomes compatible with using mcpiroman's dynamic dll loading unity package. The problem was that there is no handle to the active OpenGL context during OnPluginLoad, when using the dynamic loading package. With this minor adjustment, the renderer initialization is postponed to the first OnRenderEvent(), where there is a valid GL Context. This way the openGL profile will run in combination with mcpiroman's plugin, making it possible to change the dll without restarting Unity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this minor change, the example project becomes compatible with using mcpiroman's dynamic dll loading unity package.
The problem was that there is no handle to the active OpenGL context during OnPluginLoad, when using the dynamic loading package.
With this minor adjustment, the renderer initialization is postponed to the first OnRenderEvent(), where there is a valid GL Context.
This way the openGL profile will run in combination with mcpiroman's plugin, making it possible to change the dll without restarting Unity.