Skip to content

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 6, 2026

Description

Clarify Control Type tooltip to avoid “Button” terminology

Updates the Control Type tooltip to describe value shapes (e.g. Digital, Vector2, Stick) instead of semantic inputs like “Button”. This better reflects how the Input System interprets control types and avoids confusion when configuring bindings.

https://jira.unity3d.com/browse/ISX-1736

Testing status & QA

Not tested

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 6, 2026
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR consists solely of a text update to a [Tooltip] attribute in a single file.
🏅 Score: 100

The changes are minimal, safe, and purely cosmetic (documentation update), with no impact on runtime logic.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@josepmariapujol-unity josepmariapujol-unity changed the title Update InputActions.cs tooltip Fix: Update tooltip for Action > Control type Jan 6, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title Fix: Update tooltip for Action > Control type FIX: Update tooltip for Action > Control type Jan 6, 2026
@codecov-github-com
Copy link

codecov-github-com bot commented Jan 6, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2307   +/-   ##
========================================
  Coverage    77.95%   77.96%           
========================================
  Files          477      476    -1     
  Lines        97419    97443   +24     
========================================
+ Hits         75943    75967   +24     
  Misses       21476    21476           
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_MacOS_2022.3_project 75.47% <ø> (-0.03%) ⬇️
inputsystem_MacOS_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.06%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.37% <ø> (-0.05%) ⬇️
inputsystem_Ubuntu_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_2022.3_project 75.26% <ø> (-0.03%) ⬇️
inputsystem_Ubuntu_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (-0.06%) ⬇️
inputsystem_Ubuntu_6000.5 5.33% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (-0.06%) ⬇️
inputsystem_Windows_2022.3 5.54% <ø> (-0.01%) ⬇️
inputsystem_Windows_2022.3_project 75.60% <ø> (-0.02%) ⬇️
inputsystem_Windows_6000.0 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.4 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 77.49% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.5 5.32% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ity.inputsystem/InputSystem/Actions/InputAction.cs 92.19% <ø> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josepmariapujol-unity josepmariapujol-unity changed the title FIX: Update tooltip for Action > Control type FIX: Update tooltip for Action > Control type to avoid “Button” terminology Jan 6, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title FIX: Update tooltip for Action > Control type to avoid “Button” terminology FIX: Tooltip bug for Action > Control type to avoid “Button” terminology Jan 6, 2026
@josepmariapujol-unity josepmariapujol-unity merged commit 6a58700 into develop Jan 7, 2026
128 of 133 checks passed
@josepmariapujol-unity josepmariapujol-unity deleted the input/isx-1736/tooltip-fix branch January 7, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants