FIX: GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum resolving to wrong integers (ISXB-1270)#2100
Merged
adrian-koretski-unity3d merged 5 commits intodevelopfrom Jan 24, 2025
Merged
Conversation
…alues not matching displayed dropdown values in editor when using GamepadButtonPropertyDrawer.
ekcoh
approved these changes
Jan 17, 2025
Collaborator
ekcoh
left a comment
There was a problem hiding this comment.
Not sure I follow the logical changes to the property drawer completely, but if this successfully resolved string to value mapping for the property drawer editor it's all good to me. Maybe add some inline comments to the code explaining what you achieve with the added SetEnumDisplayNames for readability?
Collaborator
|
Added QA representative to PR for testing. Recommend looking for consistent mapping among all entries of the enum. |
Pauliusd01
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue arises from enum values that do not correspond to their index in the array (such as the triggers). The fix is to map the index values to the enum values.
Testing status & QA
Tested by selecting the problematic values in editor and verifying that they correctly select the associated enum values.
Overall Product Risks
Low risk
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: