Conversation
…and not cleaned when exiting Unity Editor (ISX-2140)
ekcoh
approved these changes
Dec 17, 2024
Collaborator
ekcoh
left a comment
There was a problem hiding this comment.
Makes sense to make part of Library instead. Thanks for the fix.
Collaborator
|
Added QA representative for quality check since not covered by automated tests. |
Collaborator
|
@bitter Suggesting adding a line to https://github.com/Unity-Technologies/InputSystem/blob/develop/Packages/com.unity.inputsystem/CHANGELOG.md according to other patterns for ISXB issues. |
Pauliusd01
approved these changes
Dec 18, 2024
Contributor
Author
done - 6a1b455 |
Contributor
Author
|
Thank you @Pauliusd01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ISX-2140
Fix location of link xml file. We need a location that is persistent and not cleaned when exiting Unity Editor
Testing status & QA
Tested locally building an Android IL2CPP variation.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: