FIX: Arrow key navigation of Input Actions after Action rename.#2082
FIX: Arrow key navigation of Input Actions after Action rename.#2082
Conversation
ekcoh
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks for adding a corresponding test case to prevent future regression.
| } | ||
|
|
||
| [UnityTest] | ||
| public IEnumerator CanRenameAction() |
There was a problem hiding this comment.
Awesome you've added a proper editor test for this. Thank you!
6181acc to
249949b
Compare
|
If you duplicate while in rename mode that action stays in rename mode instead of cancelling it 10.12.2024.-.Unity.68.mp4 |
|
Odd behaviour after renaming a map -> action and then action again 10.12.2024.-.Unity.69.mp4 |
Pauliusd01
left a comment
There was a problem hiding this comment.
Still seeing the context menu issues
https://github.com/user-attachments/assets/a96ee113-e232-4fac-aacd-af6fabf6f318
@Pauliusd01 Turns out this wasn't happening on Mac, only on Windows which is why I thought I'd fixed it already. Should be fixed in f010303 |
Description
ActionsTreeView should use RefreshItems in Unity 6000.0 onwards to have the same behaviour as ActionMapsView. This allows keyboard navigation after renaming.
It is not a perfect fix, as the limitations of UIToolkit and InputSystem refresh mean that the action will still lose focus occasionally. However this is the current behaviour of Action Maps and Actions should match that as closely as possible.
Testing status & QA
Local Testing.
Added new CanRenameAction test.
Overall Product Risks
Complexity: Low
Halo Effect: None
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: