Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS interpreter observer #268

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

TS interpreter observer #268

wants to merge 6 commits into from

Conversation

CaelmBleidd
Copy link
Member

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2025
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 26, 2025
View reviewed changes
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
@Suppress("unused")
interface TsInterpreterObserver : UInterpreterObserver {
fun onAssignStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsAssignStmt, scope: TsStepScope) {}
// TODO on entry point

Check warning

Code scanning / detekt

Declarations and declarations with comments should have an empty space between. Warning

Declarations and declarations with comments should have an empty space between.
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
interface TsInterpreterObserver : UInterpreterObserver {
fun onAssignStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsAssignStmt, scope: TsStepScope) {}
// TODO on entry point
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
interface TsInterpreterObserver : UInterpreterObserver {
fun onAssignStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsAssignStmt, scope: TsStepScope) {}
// TODO on entry point
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
interface TsInterpreterObserver : UInterpreterObserver {
fun onAssignStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsAssignStmt, scope: TsStepScope) {}
// TODO on entry point
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Detects mis-aligned parameter lists Warning

Parameter should start on a newline
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
interface TsInterpreterObserver : UInterpreterObserver {
fun onAssignStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsAssignStmt, scope: TsStepScope) {}
// TODO on entry point
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Detects mis-aligned parameter lists Warning

Parameter should start on a newline
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}
// TODO onCallWithResolvedArguments
fun onIfStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, scope: TsStepScope) {}
fun onIfStatementWithResolvedCondition(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, condition: UBoolExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Detects mis-aligned parameter lists Warning

Parameter should start on a newline
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}
// TODO onCallWithResolvedArguments
fun onIfStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, scope: TsStepScope) {}
fun onIfStatementWithResolvedCondition(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, condition: UBoolExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Detects mis-aligned parameter lists Warning

Parameter should start on a newline
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}
// TODO onCallWithResolvedArguments
fun onIfStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, scope: TsStepScope) {}
fun onIfStatementWithResolvedCondition(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, condition: UBoolExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Detects mis-aligned parameter lists Warning

Missing newline before ")"
usvm-ts/src/main/kotlin/org/usvm/machine/TsInterpreterObserver.kt
fun onCallWithUnresolvedArguments(simpleValueResolver: TsSimpleValueResolver, stmt: EtsCallExpr, scope: TsStepScope) {}
// TODO onCallWithResolvedArguments
fun onIfStatement(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, scope: TsStepScope) {}
fun onIfStatementWithResolvedCondition(simpleValueResolver: TsSimpleValueResolver, stmt: EtsIfStmt, condition: UBoolExpr, scope: TsStepScope) {}

Check warning

Code scanning / detekt

Reports missing newlines (e.g. between parentheses of a multi-line function call Warning

Missing newline after "{"
usvm-ts/src/main/kotlin/org/usvm/machine/interpreter/TsInterpreter.kt
scope.doWithState {
with(ctx) {
val resultSort = typeToSort(stmt.expr.method.returnType)
val resultValue = when (resultSort) {

Check warning

Code scanning / detekt

Braces do not comply with the specified policy Warning

Inconsistent braces, make sure all branches either have or don't have braces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaelmBleidd @Lipen