Chore: update BaseHook.sol license #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
approved these changes
Oct 6, 2023
|
hey team - I need to go back and sign these commits to get this merged i think. But in figuring that out, Atis pointed out that there are a bunch of contracts with the SPDX identifier of Given that the readme says the repo is governed by GPL 2.0, would it make sense for me to change the |
|
Hi! Sorry for the delay we were focussing on v4-core for a while. I think best to do licensing separately so please can you just sign the commits for this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
BaseHook.solwill likely be a required import to any hook contracts or protocols that are built on top of v4. In talking to developers who are likely to build these types of contracts and protocols, the Uniswap Foundation has surfaced a common concern around the restrictions enforced byBaseHook.sol's GPL license.Description of changes
This PR changes the SPDX License Identifier in
BaseHook.solto MIT. It also edits the License section of the README to note the new exceptions to the GPL that governs most of the repository.