Rename hook errors to be more descriptive #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Hi, I had a question but I'm wagering that this is easy in the interest of time/effort... so rather than creating a separate issue and PR, I'm including the question inline here alongside the PR.
I'm not wedded to the code so if it gets declined, no big deal.
Is there a compelling reason why
HookNotImplementedis shared across the eight lifecycle events? I'm doing some light fuzzing work with @khegeman and having a single error made it a bit challenging to discover where our code was failing.I found great use out of dedicated errors and I wanted to pass it along... but again, if this provides no value (or negative value), feel free to decline.
Description of changes
This PR creates explicit errors for where execution of a hook is attempted despite it not being implemented.