Remove mandatory IR #421
Merged
Remove mandatory IR #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
commented
Dec 18, 2024
snapshots/PosMGasTest.json
Outdated
| "PositionManager_permit_twice": "44975", | ||
| "PositionManager_subscribe": "87968", | ||
| "PositionManager_unsubscribe": "62697", | ||
| "position manager initcode hash (without constructor params, as uint256)": "81827502601055975118808937107769364319765058198432540518516360048852193272922", |
There was a problem hiding this comment.
reverts back to whats in main rn
|
me looking for the via-IR apologists |
snreynolds
approved these changes
Dec 18, 2024
|
@saucepoint Huge THANK YOU for removing IR! Speeds up edit-test loop so much. |
|
credit goes to @abdulla-cb for implementation! im just his agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Reverting compilation changes, and bringing Abs' branch up to date
replaces #416
Description of changes