Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use notifyBurn #399

Merged
merged 4 commits into from
Nov 25, 2024
Merged

use notifyBurn #399

merged 4 commits into from
Nov 25, 2024

Conversation

snreynolds
Copy link
Member

Related Issue

Which issue does this pull request resolve?

Description of changes

saucepoint
saucepoint previously approved these changes Nov 23, 2024
Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im happy with this -- you are right that it feels weird to have two different places call delete subscriber[tokenId];

we could use an internal function but thats only marginally better

@snreynolds snreynolds merged commit 4ac5f57 into main Nov 25, 2024
3 checks passed
@snreynolds snreynolds deleted the notifyBurn branch November 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants