Optimise actions encoding #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Aug 1, 2024
|
|
||
| uint256 numActions = actions.length; | ||
| if (numActions != params.length) revert InputLengthMismatch(); | ||
|
|
||
| for (uint256 actionIndex = 0; actionIndex < numActions; actionIndex++) { | ||
| uint256 action = actions[actionIndex]; | ||
| uint256 action = uint256(uint8(actions[actionIndex])); |
There was a problem hiding this comment.
would this line be incorrect to do uint256(actions[actionIndex]) ?
There was a problem hiding this comment.
wont compile because actions[actionIndex] is a bytes1 so you have to cast it via uint8
There was a problem hiding this comment.
you always have to cast to a different type of the same size before you change sizes.
e.g. if you have int128 and you want uint256 you have to do uint256(uint128(int128))
so in this case you have ot go to uint8 because its the same size as bytes1
snreynolds
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all our actions are well within 1 byte, but are being encoded as an array of 256 bit numbers - very wasteful on calldata. Now theyre packed as 1 byte commands like in the UR