remove isApprovedOrOwner from increase #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Jul 25, 2024
snreynolds
previously approved these changes
Jul 26, 2024
hensha256
reviewed
Jul 26, 2024
| @@ -164,6 +165,53 @@ contract IncreaseLiquidityTest is Test, PosmTestSetup, Fuzzers { | |||
| assertApproxEqAbs(balance1BeforeAlice, currency1.balanceOf(alice), tolerance); | |||
| } | |||
|
|
|||
| function test_increaseLiquidity_withUnapprovedCaller() public { | |||
| // Alice and Bob provide liquidity on the range | |||
| // Alice uses her exact fees to increase liquidity (compounding) | |||
There was a problem hiding this comment.
i feel like this is quite a complicated test to just test something thats not as complicated?
might be easier to have just 1 person providing liquidity not 2.
Just like
- Call 1: Alice mints herself a position
- Call 2: Bob increases liquidity in alices position
No need for Bob to have a position in the same range that feels like its confusing it a bit
hensha256
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
anyone can increase anyone else's position - they don't need to be the owner or approved
Description of changes
remove isApprovedOrOwner check from increase