Code

add position manager [wip]#141

Code

Merged

snreynolds merged 112 commits intomainUniswap/v4-periphery:mainfrom dev-posmUniswap/v4-periphery:dev-posmCopy head branch name to clipboardJul 23, 2024

+2,192-194

Commits

Commits on Dec 5, 2023

• initial thoughts lock and batch

  snreynolds

  committed
  6c63e1f

  Copy full SHA for 6c63e1f

• update safecallback with constructor

  snreynolds

  committed
  ad39d19

  Copy full SHA for ad39d19

Commits on Dec 6, 2023

• simple batch under lock

  snreynolds

  committed
  64fc40a

  Copy full SHA for 64fc40a

• oops

  snreynolds

  committed
  a707c20

  Copy full SHA for a707c20

Commits on Feb 23, 2024

• misc version bump; will conflict but can resolve later

  saucepoint

  committed
  1d0e566

  Copy full SHA for 1d0e566

• defining types and different levels of abstractions

  saucepoint

  committed
  4f8bbd2

  Copy full SHA for 4f8bbd2

Commits on Mar 1, 2024

• merge in main; resolve conflicts

  saucepoint

  committed
  c4c9dcd

  Copy full SHA for c4c9dcd

• merge in main?

  saucepoint

  committed
  187fc3d

  Copy full SHA for 187fc3d

Commits on Mar 2, 2024

• wip

  saucepoint

  committed
  ee27f4f

  Copy full SHA for ee27f4f

• merge in main

  saucepoint

  committed
  30ac060

  Copy full SHA for 30ac060

• misc fixes with main:latest

  saucepoint

  committed
  d1c5897

  Copy full SHA for d1c5897

Commits on Mar 3, 2024

• basic mint

  saucepoint

  committed
  7a134a5

  Copy full SHA for 7a134a5

Commits on Mar 4, 2024

• begin moving tests to fuzz

  saucepoint

  committed
  7bd2996

  Copy full SHA for 7bd2996

Commits on Mar 5, 2024

• test for slippage

  saucepoint

  committed
  307f4bb

  Copy full SHA for 307f4bb

Commits on Mar 6, 2024

• burning

  saucepoint

  committed
  109caf4

  Copy full SHA for 109caf4

• decrease liquidity

  saucepoint

  committed
  1bf080f

  Copy full SHA for 1bf080f

Commits on Mar 7, 2024

• mint transfer burn, liquidityOf accounting

  saucepoint

  committed
  40f042c

  Copy full SHA for 40f042c

Commits on Mar 8, 2024

• wip

  saucepoint

  committed
  6b1c7cb

  Copy full SHA for 6b1c7cb

Commits on Mar 12, 2024

• refactor to use CurrencySettleTake

  saucepoint

  committed
  fa511d0

  Copy full SHA for fa511d0

• basic fee collection

  saucepoint

  committed
  a0e0a44

  Copy full SHA for a0e0a44

Commits on Mar 16, 2024

• wip

  saucepoint

  committed
  0d936d4

  Copy full SHA for 0d936d4

Commits on Mar 19, 2024

• misc fix

  saucepoint

  committed
  4be3c2a

  Copy full SHA for 4be3c2a

• fee collection for independent same-range parties

  saucepoint

  committed
  7fa4c54

  Copy full SHA for 7fa4c54

• LiquidityPosition -> LiquidityRange

  saucepoint

  committed
  aae9697

  Copy full SHA for aae9697

• erc20 fee collection

  saucepoint

  committed
  5dec534

  Copy full SHA for 5dec534

Commits on Mar 25, 2024

• decrease liquidity with fee collection

  saucepoint

  committed
  1196c6a

  Copy full SHA for 1196c6a

Commits on Mar 26, 2024

• wip test decrease liquidity on same range

  saucepoint

  committed
  3d317e8

  Copy full SHA for 3d317e8

• reworked fuzzers; more testing on fee claims for liquidity decreasing

  saucepoint

  committed
  31a70cb

  Copy full SHA for 31a70cb

Commits on Mar 27, 2024

• merge in main; update flipped deltas; update lockAcquired signature

  saucepoint

  committed
  f844687

  Copy full SHA for f844687

• forge fmt

  saucepoint

  committed
  666faf8

  Copy full SHA for 666faf8

• Merge remote-tracking branch 'parent/lock-and-batch-call' into position-manager

  saucepoint

  committed
  714913e

  Copy full SHA for 714913e

• Merge branch 'position-manager' of github.com:saucepoint/v4-periphery into position-manager

  saucepoint

  committed
  ddf5771

  Copy full SHA for ddf5771

• test fixes for flipped deltas

  saucepoint

  committed
  3c56d48

  Copy full SHA for 3c56d48

Commits on Apr 3, 2024

• wip

  saucepoint

  committed
  f4275cc

  Copy full SHA for f4275cc

Commits on Apr 5, 2024

• test coverage for increase liquidity cases

  saucepoint

  committed
  245cc3e

  Copy full SHA for 245cc3e

• preliminary gas benchmarks

  saucepoint

  committed
  f971b3d

  Copy full SHA for f971b3d

Commits on Jun 3, 2024

• merge in main; fix breaking changes

  saucepoint

  committed
  0f9936e

  Copy full SHA for 0f9936e

• merge in changes

  saucepoint

  committed
  41619f9

  Copy full SHA for 41619f9

Commits on Jun 7, 2024

• Position manager refactor (#2)

  Show description for 0165be5
  

  saucepoint

  and

  qiwu7

  authored
  0165be5

  Copy full SHA for 0165be5

Commits on Jun 9, 2024

• fix conflicts

  saucepoint

  committed
  d86a8c2

  Copy full SHA for d86a8c2

Commits on Jun 12, 2024

• cleanup: TODOs and imports

  saucepoint

  committed
  52b304e

  Copy full SHA for 52b304e

• Position manager Consolidate (#3)

  Show description for af67661
  saucepoint

  authored
  af67661

  Copy full SHA for af67661

• use currency settler syntax

  saucepoint

  committed
  48f38c4

  Copy full SHA for 48f38c4

Commits on Jun 13, 2024

• use v4-core's gas snapshot

  saucepoint

  committed
  c8ce67b

  Copy full SHA for c8ce67b

• use snapLastCall and isolate for posm benchmarks

  saucepoint

  committed
  da91136

  Copy full SHA for da91136

Commits on Jun 14, 2024

• Update contracts/libraries/CurrencySettleTake.sol

  Show description for 18600bd
  

  saucepoint

  and

  qiwu7

  authored
  18600bd

  Copy full SHA for 18600bd

• use v4-core's solmate its more recent

  saucepoint

  committed
  f52adcf

  Copy full SHA for f52adcf

Commits on Jun 17, 2024

• use v4-core's openzeppelin-contracts

  saucepoint

  committed
  07cc628

  Copy full SHA for 07cc628

• add ERC721Permit

  saucepoint

  committed
  240c8e1

  Copy full SHA for 240c8e1

• feedback: memory hookData

  saucepoint

  committed
  1cb1948

  Copy full SHA for 1cb1948

Commits on Jun 19, 2024

• initial refactor. stack too deep

  saucepoint

  committed
  227683b

  Copy full SHA for 227683b

• passing tests

  saucepoint

  committed
  a19636f

  Copy full SHA for a19636f

• merge in main

  saucepoint

  committed
  ea56ec2

  Copy full SHA for ea56ec2

• gutted LockAndBatchCall

  saucepoint

  committed
  fc04651

  Copy full SHA for fc04651

• cleanup diff

  saucepoint

  committed
  e1d55f8

  Copy full SHA for e1d55f8

• renaming vanilla functions

  saucepoint

  committed
  b73a240

  Copy full SHA for b73a240

Commits on Jun 20, 2024

• sanitize

  saucepoint

  committed
  2227265

  Copy full SHA for 2227265

Commits on Jun 26, 2024

• change add liq accounting (#126)

  Show description for 0cff6ef
  

  snreynolds

  and

  saucepoint

  authored
  0cff6ef

  Copy full SHA for 0cff6ef

• create compatibility with arbitrary execute handler

  saucepoint

  committed
  e21e847

  Copy full SHA for e21e847

• being supporting batched ops on vanilla functions

  saucepoint

  committed
  1e52f82

  Copy full SHA for 1e52f82

• some initial tests to drive TDD

  saucepoint

  committed
  97080cb

  Copy full SHA for 97080cb

• gas with isolate

  saucepoint

  committed
  80b5185

  Copy full SHA for 80b5185

Commits on Jun 27, 2024

• mint to recipient

  saucepoint

  committed
  93f012e

  Copy full SHA for 93f012e

• refactor for external call and code reuse (#134)

  saucepoint

  authored
  cc031aa

  Copy full SHA for cc031aa

Commits on Jun 28, 2024

• updated interface with unlockAndExecute

  saucepoint

  committed
  1995c9e

  Copy full SHA for 1995c9e

• update decrease (#133)

  Show description for 0d6ab0b
  snreynolds

  authored
  0d6ab0b

  Copy full SHA for 0d6ab0b

• merge in posm-batch and fix

  saucepoint

  committed
  635ebe3

  Copy full SHA for 635ebe3

• fix bubbling different return types because of recursive calls

  saucepoint

  committed
  406506f

  Copy full SHA for 406506f

Commits on Jun 29, 2024

• all operations only return a BalanceDelta type (#136)

  saucepoint

  authored
  fae83dc

  Copy full SHA for fae83dc

Commits on Jul 9, 2024

• temp-dev-update (#135)

  Show description for 7db4e14
  

  saucepoint

  and

  snreynolds

  authored
  7db4e14

  Copy full SHA for 7db4e14

Commits on Jul 12, 2024

• using internal calls, first pass (#143)

  Show description for a565e0f
  snreynolds

  authored
  a565e0f

  Copy full SHA for a565e0f

• dumb fix to test ci (#146)

  Show description for 4cec450
  

  snreynolds

  and

  gretzke

  authored
  4cec450

  Copy full SHA for 4cec450

Commits on Jul 17, 2024

• some more gas snapshots (#150)

  saucepoint

  authored
  f4793e0

  Copy full SHA for f4793e0

• feat: posm, use salts for all positions & update permit (#148)

  Show description for 77ff368
  

  3 peopleauthored
  77ff368

  Copy full SHA for 77ff368

• merge main

  snreynolds

  committed
  77527f6

  Copy full SHA for 77527f6

Commits on Jul 18, 2024

• Multicall & initialize (#154)

  Show description for 07a3e63
  

  saucepoint

  and

  snreynolds

  authored
  07a3e63

  Copy full SHA for 07a3e63

• prep shared actions (#158)

  snreynolds

  authored
  cae6ed6

  Copy full SHA for cae6ed6

• update main (#162)

  snreynolds

  authored
  08f15e7

  Copy full SHA for 08f15e7

• Merge branch 'main' of github.com:Uniswap/periphery-next into dev-posm

  snreynolds

  committed
  7ff81b1

  Copy full SHA for 7ff81b1

• ERC721Permit cleanup (#161)

  Show description for 85bab02
  

  saucepoint

  and

  snreynolds

  authored
  85bab02

  Copy full SHA for 85bab02

• remove old files, imports

  snreynolds

  committed
  7c87344

  Copy full SHA for 7c87344

Commits on Jul 19, 2024

• Update src/NonfungiblePositionManager.sol

  Show description for 55978ac
  

  snreynolds

  and

  saucepoint

  authored
  55978ac

  Copy full SHA for 55978ac

• pr comments

  snreynolds

  committed
  4a3d64a

  Copy full SHA for 4a3d64a

• pr comments

  snreynolds

  committed
  8f1be9f

  Copy full SHA for 8f1be9f

• Merge branch 'main' into dev-posm

  snreynolds

  authored
  7eb01a6

  Copy full SHA for 7eb01a6

• refactor test helpers per feedback

  saucepoint

  committed
  a35b9ea

  Copy full SHA for a35b9ea

• fix gas

  snreynolds

  committed
  bc1ee23

  Copy full SHA for bc1ee23

• remove permit

  snreynolds

  committed
  026c1b0

  Copy full SHA for 026c1b0

• fix compiler warnings

  snreynolds

  committed
  4470dba

  Copy full SHA for 4470dba

• rename to PositionManager

  snreynolds

  committed
  af62834

  Copy full SHA for af62834

• cache length

  snreynolds

  committed
  2761404

  Copy full SHA for 2761404

• skip take for 0

  snreynolds

  committed
  bbacc75

  Copy full SHA for bbacc75

• fix tests

  snreynolds

  committed
  2adafa9

  Copy full SHA for 2adafa9

Commits on Jul 22, 2024

• Update src/interfaces/IPositionManager.sol

  Show description for f04a857
  

  saucepoint

  and

  hensha256

  authored
  f04a857

  Copy full SHA for f04a857

• update multicall tests per feedback

  saucepoint

  committed
  983ffc8

  Copy full SHA for 983ffc8

• remove unused imports

  saucepoint

  committed
  c1cab0c

  Copy full SHA for c1cab0c

• more unused imports

  saucepoint

  committed
  75b3543

  Copy full SHA for 75b3543

• improve assertion

  saucepoint

  committed
  71b1a4f

  Copy full SHA for 71b1a4f

• assert mint recipient is the payer and not the recipient

  saucepoint

  committed
  5c96bed

  Copy full SHA for 5c96bed

• pr feedback

  saucepoint

  committed
  a769478

  Copy full SHA for a769478

• assert pool creation

  saucepoint

  committed
  49a02ce

  Copy full SHA for 49a02ce

• use poolManager

  snreynolds

  committed
  bbaf355

  Copy full SHA for bbaf355

• remove liquidityrange imports

  snreynolds

  committed
  538a0fb

  Copy full SHA for 538a0fb

• remove version string

  snreynolds

  committed
  b215934

  Copy full SHA for b215934

• pr comments, use base test setup

  snreynolds

  committed
  6093c4b

  Copy full SHA for 6093c4b

• fuzz sqrtPrice

  snreynolds

  committed
  84f9629

  Copy full SHA for 84f9629

• use fuzz, assert eq

  snreynolds

  committed
  7dbc6b2

  Copy full SHA for 7dbc6b2

• other final rand pr comment fixes

  snreynolds

  committed
  decc745

  Copy full SHA for decc745

• fix off by 1

  snreynolds

  committed
  7dfdbeb

  Copy full SHA for 7dfdbeb

• use bound

  snreynolds

  committed
  d7c358c

  Copy full SHA for d7c358c

• merge main

  snreynolds

  committed
  c579a64

  Copy full SHA for c579a64

Commits on Jul 23, 2024

• use nextTokenId

  snreynolds

  committed
  04660de

  Copy full SHA for 04660de