implement safe transfer from as in the todo for the example #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Jun 26, 2024
| @@ -264,7 +266,7 @@ contract FullRange is BaseHook, ILockCallback { | |||
| if (sender == address(this)) { | |||
| currency.transfer(address(poolManager), amount); | |||
| } else { | |||
| IERC20Minimal(Currency.unwrap(currency)).transferFrom(sender, address(poolManager), amount); | |||
| SafeERC20.safeTransferFrom(IERC20(Currency.unwrap(currency)), sender, address(poolManager), amount); | |||
There was a problem hiding this comment.
hi! please could you use
using SafeERC20 for IERC20
and then just token.safeTransferFrom?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Solves #107
Description of changes
Implements the safetransferfrom in the example