use address for subscriber (#405)

* use address for subscriber * fix bytecode snap
Uniswap · Dec 2, 2024 · c71e4b9 · c71e4b9
1 parent c3d3cad
commit c71e4b9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/.forge-snapshots/positionDescriptor bytecode size.snap b/.forge-snapshots/positionDescriptor bytecode size.snap
@@ -1 +1 @@
-24108
+24177
diff --git a/src/base/Notifier.sol b/src/base/Notifier.sol
@@ -96,32 +96,28 @@ abstract contract Notifier is INotifier {
         uint256 liquidity,
         BalanceDelta feesAccrued
     ) internal {
-        ISubscriber _subscriber = subscriber[tokenId];
+        address _subscriber = address(subscriber[tokenId]);
 
         // remove the subscriber
         delete subscriber[tokenId];
 
-        bool success = _call(
-            address(_subscriber), abi.encodeCall(ISubscriber.notifyBurn, (tokenId, owner, info, liquidity, feesAccrued))
-        );
+        bool success =
+            _call(_subscriber, abi.encodeCall(ISubscriber.notifyBurn, (tokenId, owner, info, liquidity, feesAccrued)));
 
         if (!success) {
-            address(_subscriber).bubbleUpAndRevertWith(
-                ISubscriber.notifyBurn.selector, BurnNotificationReverted.selector
-            );
+            _subscriber.bubbleUpAndRevertWith(ISubscriber.notifyBurn.selector, BurnNotificationReverted.selector);
         }
     }
 
     function _notifyModifyLiquidity(uint256 tokenId, int256 liquidityChange, BalanceDelta feesAccrued) internal {
-        ISubscriber _subscriber = subscriber[tokenId];
+        address _subscriber = address(subscriber[tokenId]);
 
         bool success = _call(
-            address(_subscriber),
-            abi.encodeCall(ISubscriber.notifyModifyLiquidity, (tokenId, liquidityChange, feesAccrued))
+            _subscriber, abi.encodeCall(ISubscriber.notifyModifyLiquidity, (tokenId, liquidityChange, feesAccrued))
         );
 
         if (!success) {
-            address(_subscriber).bubbleUpAndRevertWith(
+            _subscriber.bubbleUpAndRevertWith(
                 ISubscriber.notifyModifyLiquidity.selector, ModifyLiquidityNotificationReverted.selector
             );
         }