Refactor test file imports by removing duplicates and standardizing order#951
Open
gkfyr wants to merge 3 commits intoUniswap:mainfrom
Open
Refactor test file imports by removing duplicates and standardizing order#951gkfyr wants to merge 3 commits intoUniswap:mainfrom
gkfyr wants to merge 3 commits intoUniswap:mainfrom
Conversation
0xb10ckdev
reviewed
Mar 19, 2025
test/CustomAccounting.t.sol
Outdated
| import {PoolId} from "../src/types/PoolId.sol"; | ||
| import {IPoolManager} from "../src/interfaces/IPoolManager.sol"; | ||
| import {Currency} from "../src/types/Currency.sol"; | ||
| import {BalanceDelta} from "../src/types/BalanceDelta.sol"; |
There was a problem hiding this comment.
If you want to standardizing order, it should be ordered alphabetically
Suggested change
| import {PoolId} from "../src/types/PoolId.sol"; | |
| import {IPoolManager} from "../src/interfaces/IPoolManager.sol"; | |
| import {Currency} from "../src/types/Currency.sol"; | |
| import {BalanceDelta} from "../src/types/BalanceDelta.sol"; | |
| import {BalanceDelta} from "../src/types/BalanceDelta.sol"; | |
| import {Currency} from "../src/types/Currency.sol"; | |
| import {PoolId} from "../src/types/PoolId.sol"; |
Author
There was a problem hiding this comment.
I reordered the imports alphabetically and pushed a new commit. Thanks! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
closes #950
Description of Changes