Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ N16: Create SECURITY.md #774

Merged
merged 4 commits into from
Jul 14, 2024
Merged

OZ N16: Create SECURITY.md #774

merged 4 commits into from
Jul 14, 2024

Conversation

gretzke
Copy link
Contributor

@gretzke gretzke commented Jul 9, 2024

Description of changes

Add file with security information

@gretzke gretzke changed the title Create SECURITY.md OZ N16: Create SECURITY.md Jul 9, 2024
@@ -0,0 +1,13 @@
# Uniswap Labs Security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The audit also says

Consider adding a NatSpec comment containing a security contact above each contract definition. Using the @custom:security-contact convention is recommended

Shall we add the contact at the top of the PoolManager too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against it but I'm also fine with just the security file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fair i'll merge

@hensha256 hensha256 merged commit 818a3d0 into audit/openzeppelin Jul 14, 2024
5 checks passed
@hensha256 hensha256 deleted the fix/n16 branch July 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants