Fix #752: Reuse _computeSlot result in _accountDelta #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This saves a few hundred gas now but it will be a few thousand gas after https://eips.ethereum.org/EIPS/eip-7667 |
wjmelements
changed the title
hensha256
reviewed
Jul 14, 2024
|
Sorry for the delay we've been having audits so the code was frozen. We are starting another set of audits this week so lets try to merge this... today if possible? |
|
Nice thanks for doing that. I've asked @snreynolds to take a look too which hopefully she will do today. |
|
The coverage error is 403 unauthorized. It appears that you need to authorize Here is what it was trying to post:Forge code coverage:
|
|
Yep no worries! Its just because youre working from a fork branch and they cannot access our github secrets :) |
snreynolds
requested changes
Jul 14, 2024
snreynolds
reviewed
Jul 15, 2024
hensha256
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers @snreynolds @marktoda @hensha256
Fixes #752
Changes