Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ROI Metrics for Pools #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include ROI Metrics for Pools #123

wants to merge 1 commit into from

Conversation

danpaquin
Copy link

  1. Add 24H Fees to Pools Table

Fees

  1. Add Return on Liquidity (ROL) Metric to Chart

ROL

@vercel
Copy link

vercel bot commented Jul 19, 2021

@danpaquin is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/v3-info/9d8By5sw52d3sq1QajNA5uqRUsV1
✅ Preview: https://v3-info-git-fork-danpaquin-add-chart-trd-cnt-uniswap.vercel.app

@ianlapham
Copy link
Member

Great start here - like the idea of ROL on the chart. I wonder if we should transform it to be annulaized - or find some way to explain what that metric means on the chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NAGAHAMAAKIRA NAGAHAMAAKIRA NAGAHAMAAKIRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danpaquin @ianlapham @NAGAHAMAAKIRA