fix(v4-sdk): V4 planner accommodates exactOut + granular take/settles #97
Conversation
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/12/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
ewilz
changed the title
|
|
||
| describe('RouterPlanner', () => { | ||
| let planner: V4Planner | ||
|
|
||
| beforeEach(() => { | ||
| planner = new V4Planner() | ||
| // console.log(planner) |
| const FULL_DELTA_AMOUNT = 0 | ||
| const MSG_SENDER = '0x0000000000000000000000000000000000000001' | ||
| const ADDRESS_THIS = '0x0000000000000000000000000000000000000002' | ||
|
|
There was a problem hiding this comment.
ooh nice I made an ActionsConstant utils file, I can put these in there later when my PR gets merged
There was a problem hiding this comment.
yah feel free to move around. this file is def pretty cray
| ? { | ||
| currencyOut, | ||
| path: encodeRouteToPath(trade.route, exactOutput), | ||
| amountInMaximum: trade.maximumAmountIn(slippageTolerance ?? new Percent(0)).quotient.toString(), |
There was a problem hiding this comment.
it looks like on 128 we check that slippageTolerance is required? so can we just pass it in directly here?
| const actionType = trade.tradeType === TradeType.EXACT_INPUT ? Actions.SWAP_EXACT_IN : Actions.SWAP_EXACT_OUT | ||
| const exactOutput = trade.tradeType === TradeType.EXACT_OUTPUT | ||
|
|
||
| if (exactOutput) invariant(!!slippageTolerance, 'ExactOut requires slippageTolerance') |
There was a problem hiding this comment.
how come we only check this for exactOuput? just curious
There was a problem hiding this comment.
good question I can leave a comment. on exactInput sometimes we do agg slippage checks so we don't need to know slippage, but we enver do that on exactOutput
| ]) | ||
| } | ||
|
|
||
| addSettle(currency: Currency, payerIsUser: boolean, amount?: BigNumber): void { |
There was a problem hiding this comment.
nit: should we add comment headers?
No description provided.