fix(universal-router-sdk): only do aggregated slippage check for trades with multiple routes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
force-pushed
the
aggregatedSlippage
branch
from
87cf40d to
7569a2f
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/10/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
ewilz
changed the title
ewilz
changed the title
zhongeric
approved these changes
Sep 12, 2024
hensha256
reviewed
Sep 19, 2024
| @@ -187,7 +187,8 @@ function addV2Swap<TInput extends Currency, TOutput extends Currency>( | |||
| // if native, we have to unwrap so keep in the router for now | |||
| routerMustCustody ? ROUTER_AS_RECIPIENT : options.recipient, | |||
| trade.maximumAmountIn(options.slippageTolerance).quotient.toString(), | |||
| trade.minimumAmountOut(options.slippageTolerance).quotient.toString(), | |||
| // if router will custody funds, we do aggregated slippage check from rotuer | |||
There was a problem hiding this comment.
Suggested change
| // if router will custody funds, we do aggregated slippage check from rotuer | |
| // if router will custody funds, we do aggregated slippage check from router |
hensha256
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.