fix(universal-router-sdk): Strip unviersal-router-sdk of NFT commands to match new UR contracts #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/05/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
marktoda
approved these changes
Sep 5, 2024
ewilz
changed the title
ewilz
changed the title
hensha256
reviewed
Sep 10, 2024
|
|
||
| invariant(!(inputIsNative && !!swapOptions.inputTokenPermit), 'NATIVE_INPUT_PERMIT') | ||
|
|
||
| if (!!swapOptions.inputTokenPermit) { |
There was a problem hiding this comment.
where does this logic happen now?
ewilz
force-pushed
the
udpate_to_new_ur
branch
from
c584f79 to
d9300e7
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected] |
ewilz
force-pushed
the
udpate_to_new_ur
branch
from
3af060c to
91b6c9b
Compare
gretzke
force-pushed
the
udpate_to_new_ur
branch
from
7f38811 to
3e3f5df
Compare
gretzke
force-pushed
the
udpate_to_new_ur
branch
from
8c92351 to
931844b
Compare
ewilz
force-pushed
the
udpate_to_new_ur
branch
from
323e8b5 to
931844b
Compare
hensha256
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dannydaniil already did a major upgrade, so we'll stick with that major version as we prepare it for v4 routing