Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breaking): esm/cjs builds for uniswapx-sdk #218

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

just-toby
Copy link
Collaborator

@just-toby just-toby commented Dec 13, 2024

PR Scope

breaking change to build structure for uniswapx-sdk

Description

updates the build setup for uniswapx-sdk to manually and explicitly create separate cjs and esm builds (plus a types-only version)

How Has This Been Tested?

built the sdk locally, then installed the local build result in another project (universe/apps/web) and verified that it properly resolved the esm version instead of the cjs version

Are there any breaking changes?

there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing the uniswapx-sdk.esm.js file) then they'll need to update

(Optional) Follow Ups

PRs to follow will do this for many other SDKs

Copy link
Collaborator Author

just-toby commented Dec 13, 2024

@just-toby just-toby changed the title feat(uniswapx): add esm build feat(breaking): add esm build Dec 13, 2024
@just-toby just-toby changed the title feat(breaking): add esm build feat(breaking): esm/cjs builds for uniswapx-sdk Dec 13, 2024
@just-toby just-toby requested a review from adjkant December 13, 2024 16:50
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from 8a61942 to 9af312f Compare December 13, 2024 16:56
@just-toby just-toby marked this pull request as ready for review December 13, 2024 16:57
@just-toby just-toby requested review from jsy1218 and a team as code owners December 13, 2024 16:57
@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch 2 times, most recently from a1cd516 to bb5c9f8 Compare December 13, 2024 17:47
Copy link
Collaborator

@adjkant adjkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but let's def discuss this as a group in terms of if this should be a major version bump or not!

@just-toby just-toby force-pushed the feat/uniswapx-sdk-esm-build branch from c4941d1 to 3bc5140 Compare December 16, 2024 23:24
Copy link

graphite-app bot commented Dec 16, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)

1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@just-toby just-toby requested a review from adjkant December 17, 2024 20:17
@just-toby just-toby merged commit b25a2de into main Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants