refactor: use length to decode relativeBlocks

Uniswap · Sep 19, 2024 · 0ca5a19 · 0ca5a19
1 parent 361f559
commit 0ca5a19
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/sdks/uniswapx-sdk/src/order/V3DutchOrder.ts b/sdks/uniswapx-sdk/src/order/V3DutchOrder.ts
@@ -531,7 +531,7 @@ function parseSerializedOrder(serialized: string): CosignedV3DutchOrderInfo {
             token,
             startAmount,
             curve: {
-                relativeBlocks: decodeRelativeBlocks(inputRelativeBlocks),
+                relativeBlocks: decodeRelativeBlocks(inputRelativeBlocks, relativeAmounts.length),
                 relativeAmounts: relativeAmounts.map((amount: BigNumber) => amount.toBigInt()),
             },
             maxAmount,
@@ -546,7 +546,7 @@ function parseSerializedOrder(serialized: string): CosignedV3DutchOrderInfo {
                 token,
                 startAmount,
                 curve: {
-                    relativeBlocks: decodeRelativeBlocks(outputRelativeBlocks),
+                    relativeBlocks: decodeRelativeBlocks(outputRelativeBlocks, relativeAmounts.length),
                     relativeAmounts: relativeAmounts.map((amount: BigNumber) => amount.toBigInt()),
                 },
                 recipient,
@@ -571,13 +571,11 @@ function encodeRelativeBlocks(relativeBlocks: number[]): BigNumber {
     return packedData;
 }
 
-function decodeRelativeBlocks(packedData: BigNumber): number[] {
+function decodeRelativeBlocks(packedData: BigNumber, relativeAmountsLength: number): number[] {
     const relativeBlocks: number[] = [];
-    for (let i = 0; i < 16; i++) {
+    for (let i = 0; i < relativeAmountsLength; i++) {
         const block = packedData.shr(i * 16).toNumber() & 0xFFFF;
-        if (block !== 0) {
-            relativeBlocks.push(block);
-        }
+        relativeBlocks.push(block);
     }
     return relativeBlocks;
 }