Fix Comment Mismatch Update cache-config.ts#949
Closed
defitricks wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the code, there was a mismatch between the comment and the actual value used for the
v2UntrackedUsdThreshold. The comment stated:// Pairs need at least 1K USD (untracked) to be selected (for metrics only)However, the value assigned to
v2UntrackedUsdThresholdis:This discrepancy creates confusion, as
Number.MAX_VALUEis effectively an extremely large value, not 1K USD. To resolve this and accurately reflect the code's behavior, the comment has been updated to:// Pairs are effectively excluded due to an untracked USD threshold of Number.MAX_VALUEThis update aligns the comment with the actual functionality and makes the code clearer.