Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Comment Mismatch Update cache-config.ts #949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

defitricks
Copy link

In the code, there was a mismatch between the comment and the actual value used for the v2UntrackedUsdThreshold. The comment stated:

// Pairs need at least 1K USD (untracked) to be selected (for metrics only)

However, the value assigned to v2UntrackedUsdThreshold is:

const v2UntrackedUsdThreshold = Number.MAX_VALUE

This discrepancy creates confusion, as Number.MAX_VALUE is effectively an extremely large value, not 1K USD. To resolve this and accurately reflect the code's behavior, the comment has been updated to:

// Pairs are effectively excluded due to an untracked USD threshold of Number.MAX_VALUE

This update aligns the comment with the actual functionality and makes the code clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant