feat(routing-api): support routing on unichain mainnet #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected] |
xrsv
commented
Nov 21, 2024
package.json
Outdated
| "@uniswap/smart-order-router": "4.8.1", | ||
| "@uniswap/router-sdk": "^1.15.0", | ||
| "@uniswap/sdk-core": "^6.0.0", | ||
| "@uniswap/smart-order-router": "file:/tmp/uniswap-smart-order-router-4.8.2.tgz", |
There was a problem hiding this comment.
update once Uniswap/smart-order-router#766 is checked in
xrsv
commented
Nov 21, 2024
cgkol
reviewed
Nov 25, 2024
| @@ -3034,7 +3036,7 @@ describe('quote', function () { | |||
| chain === ChainId.BLAST || | |||
| chain === ChainId.ZORA || | |||
| chain === ChainId.ZKSYNC || | |||
| chain === ChainId.ASTROCHAIN_SEPOLIA | |||
| chain === ChainId.UNICHAIN_SEPOLIA | |||
There was a problem hiding this comment.
dont we need to add unciahin here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support routing in Routing API for Unichain Mainnet.
Also Renames ASTROCHAIN_SEPOLIA to UNICHAIN_SEPOLIA.
Pending
universal-router-sdkandsmart-order-routeronce below PRs are checked in.feat(universal-router-sdk): support unichain mainnet on universal-router-sdk sdks#206