fix: manually include eth/wsteth with artificially high TVL #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
xrsv,
mikeki,
a team,
uni-guillaume and
cgkol
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (07/29/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
xrsv
reviewed
Jul 29, 2024
| pools = (pools as Array<V3SubgraphPool>).filter((pool: V3SubgraphPool) => { | ||
| const shouldFilterOut = | ||
| // filter out AMPL-token pools from v3 subgraph, since they are not supported on v3 | ||
| pool.token0.id.toLowerCase() === '0xd46ba6d942050d489dbd938a2c909a5d5039a161' || |
There was a problem hiding this comment.
seems this filtering already happens in line 245?
xrsv
reviewed
Jul 29, 2024
| id: '0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2', | ||
| }, | ||
| tvlETH: 706196.651729130972764273, | ||
| tvlUSD: 140465485, // same as WETH/USDC 0.05% |
There was a problem hiding this comment.
should we make this bigger or equal to the max pool?
thinking is that as tvl grows, those values might not be enough - what do you think?
mikeki
reviewed
Jul 29, 2024
Comment on lines
+236
to
+237
| tvlETH: 706196.651729130972764273, | ||
| tvlUSD: 140465485, // same as WETH/USDC 0.05% |
There was a problem hiding this comment.
This could have the downside that we might drop out other pools. We will select this pool more often now.
mikeki
reviewed
Jul 29, 2024
| tvlUSD: 140465485, // same as WETH/USDC 0.05% | ||
| } as V3SubgraphPool, | ||
| ] | ||
| manuallyIncludedPools.forEach((pool) => pools.push(pool)) |
|
we close this PR in favor of Uniswap/smart-order-router#641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though ETH/wstETH is not a high TVL pool, because of both assets close pegging, their concentrated liquidity is high within the narrow price range. We don't want to aggressively modify the pools discovery heuristics in SOR (e.g. https://app.graphite.dev/github/pr/Uniswap/smart-order-router/641/feat-mixed-Add-Cross-Liquidity-Pools-to-Mixed-Candidate-Pools?utm_source=gt-slack-notif#), so the next best thing to do is to artificually inflate the ETH/wstETH TVL during routing cron job.
I've tested locally, and now can see that 1 ETH -> DOG routes through wstETH: https://app.warp.dev/block/GnbbpKGa0e3jK2upANEQvm