chore: 1) routing-api calculates portion amount, offload unified-routing-api 2) bump sor ino routing-api 3) add portion integ-test #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
unicorn-here
commented
Oct 9, 2023
•
unicorn-here
commented
- Instead of URA calculate the portion amount, now routing-api should calculate the portion amount. This offloads URA from having to resolve token etc. See feat: portion integration retry unified-routing-api#282
- SOR released the portion support, which includes the exact out fix feat: support portion smart-order-router#425. routing-api needs to adopt it.
- routing-api adds the portion integ-test
cgkol
approved these changes
Oct 9, 2023
Yes we need to add integ-test into this PR, before we merge. |
unicorn-here
force-pushed
the
portion_calculate_amount
branch
from
c16c58c to
bdf67cf
Compare
jsy1218
changed the title
jsy1218
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.