-
Notifications
You must be signed in to change notification settings - Fork 45
Support allauth for frontend authentication needs #3622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: poc/django-auth-2
Are you sure you want to change the base?
Conversation
Test results 8 files 8 suites 4m 56s ⏱️ For more details on these failures, see this check. Results for commit ce92193. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## poc/django-auth-2 #3622 +/- ##
=====================================================
- Coverage 62.45% 59.93% -2.53%
=====================================================
Files 611 613 +2
Lines 45125 45154 +29
Branches 43 43
=====================================================
- Hits 28184 27062 -1122
- Misses 16931 18082 +1151
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0131209 to
ae75047
Compare
2e02e7a to
3f0cb18
Compare
ae75047 to
56d121f
Compare
3f0cb18 to
265c2a0
Compare
56d121f to
d233a3d
Compare
265c2a0 to
f1b4921
Compare
f1b4921 to
06c7011
Compare
|
This code statrted with a TOTP tolerance of 0, but I've had to switch it to 1. See https://www.protectimus.com/blog/time-drift-in-totp-hardware-tokens/ for why tolerance is needed and https://www.protectimus.com/token/slim/ for an offline hardware TOTP generator. |
06c7011 to
ce92193
Compare
|



Scope and purpose
Fixes #. Dependent on #.
This pull request
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.