Skip to content

Conversation

@hmpf
Copy link
Contributor

@hmpf hmpf commented Oct 22, 2025

Scope and purpose

Fixes #. Dependent on #.

This pull request

  • adds/changes/removes a dependency
  • changes the database

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Test results

    8 files      8 suites   4m 56s ⏱️
2 625 tests 2 623 ✅ 0 💤 2 ❌
5 546 runs  5 544 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit ce92193.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.93%. Comparing base (d233a3d) to head (ce92193).

Files with missing lines Patch % Lines
python/nav/web/auth/allauth/adapter.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           poc/django-auth-2    #3622      +/-   ##
=====================================================
- Coverage              62.45%   59.93%   -2.53%     
=====================================================
  Files                    611      613       +2     
  Lines                  45125    45154      +29     
  Branches                  43       43              
=====================================================
- Hits                   28184    27062    -1122     
- Misses                 16931    18082    +1151     
  Partials                  10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf hmpf force-pushed the poc/django-auth-2 branch from 0131209 to ae75047 Compare October 22, 2025 14:22
@hmpf hmpf force-pushed the poc/allauth-dataporten branch from 2e02e7a to 3f0cb18 Compare October 22, 2025 14:26
@hmpf hmpf force-pushed the poc/django-auth-2 branch from ae75047 to 56d121f Compare October 23, 2025 07:55
@hmpf hmpf force-pushed the poc/allauth-dataporten branch from 3f0cb18 to 265c2a0 Compare October 23, 2025 07:55
@hmpf hmpf force-pushed the poc/django-auth-2 branch from 56d121f to d233a3d Compare October 23, 2025 08:43
@hmpf hmpf force-pushed the poc/allauth-dataporten branch from 265c2a0 to f1b4921 Compare October 23, 2025 08:43
@hmpf hmpf force-pushed the poc/allauth-dataporten branch from f1b4921 to 06c7011 Compare October 23, 2025 09:57
@hmpf
Copy link
Contributor Author

hmpf commented Oct 23, 2025

This code statrted with a TOTP tolerance of 0, but I've had to switch it to 1.

See https://www.protectimus.com/blog/time-drift-in-totp-hardware-tokens/ for why tolerance is needed and https://www.protectimus.com/token/slim/ for an offline hardware TOTP generator.

@hmpf hmpf force-pushed the poc/allauth-dataporten branch from 06c7011 to ce92193 Compare October 23, 2025 12:04
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants