-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive library explorer #1138
Add interactive library explorer #1138
Conversation
EDIT: See up-to-date link below. |
@VojtechStep Can this interactive explorer tell you if a certain rewrite rule was used in the definition of an entry? |
Oops, I forgot to delete the link you mentioned, @fredrik-bakke. That one is from when we were testing stuff. Here is the up-to-date link: https://jobpetrovcic.github.io/Unimath-Visualization-Deployment/visualize.html |
Oh, thank you! |
8b33d99
to
1e9b94f
Compare
This one is now ready for review. @JobPetrovcic would you check if you're okay with the prose I added around the embedded graph explorer?
Unfortunately it can't. I'm not in a position to say if Agda stores this information anywhere for it to be possible. |
1e9b94f
to
ed4d3d1
Compare
I'll try to see if I can find the time tonight to review this PR! 💪 |
I'll rebase it once I get off work |
ed4d3d1
to
4a8f244
Compare
This looks great and I very much approve this PR. Very nicely done! Fredrik made some good suggestions that I second, and I have no further suggestions for changes. Thank you @JobPetrovcic for this very nice addition to the library! |
Regarding this and other feature requests: Job says he realistically won't be able to work on the underlying explorer until at least February, so that part has a feature-freeze. But he does have the intention to revisit it later, so we should collect feature requests/bugs in the meantime |
Thanks for the clarification! Where should this be filed? |
@JobPetrovcic The font hierarchy that is specified for agda code in the library is --mono-font: Menlo, Source Code Pro, Consolas, Monaco, Lucida Console,
Liberation Mono, DejaVu Sans Mono, Bitstream Vera Sans Mono, Courier New,
monospace; Fonts elsewhere in the HTML seem to be specified via the hierarchy font-family: "Open Sans", sans-serif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since every further change that was discussed is waiting for changes on the side of Job's, I suggest that we move ahead and merge this. 😁
I changed the fonts for 2, 5 to DejaVu Sans Mono and the rest to Open sans. |
Very nice! Thank you for adding that; I see the changes are live already. |
Unfortunately just changing the font-family to Open Sans doesn't do anything, unless the person viewing the website already has the font installed. We ship the font file at https://unimath.github.io/agda-unimath/fonts/open-sans-v17-all-charsets-regular.woff2 and then have a CSS file containing @font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 400;
src: local('Open Sans Regular'), local('OpenSans-Regular'),
url('open-sans-v17-all-charsets-regular.woff2') format('woff2');
} to define the Open Sans font family. It is not inherited by the iframe. Also the cascade for Again, it's not a problem to leave this until you have more time to spend on the project. Let's not lull ourselves into considering this as implemented. |
Oh, I did not know that, thank you. I reverted it, although it should take some time (~2h) for the deployment to be set back. |
Merging now after talking with Vojtech. Thank you so much again for this contribution! |
Nice! Thank you all for the swift and efficient review. |
@JobPetrovcic created an interactive graph for exploring definitions in the library. This PR embeds the explorer on our website.
Some more work is still required outside of this repository, which is why this PR is a draft.
Co-authored-by: Job Petrovčič [email protected]