Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor coproduct equivalences #1137

Merged
merged 9 commits into from
Feb 11, 2025

Conversation

morphismz
Copy link
Contributor

@morphismz morphismz commented May 5, 2024

Refactors some equivalences related to coproducs and adds one new definition.

  • removes the abstract block around is-equiv-coproduct in foundation.functorality-coproduct-types, thus allowing map-inv-equiv (equiv-coproduct e e') to compute to map-coproduct (map-inv-equiv e) (map-inv-equiv e'). We keep abstract blocks around the proof that the inverse map is a section and retraction

  • computes the underlying map of the equivalence Fin-add-ℕ in univalent-combinatorics.coproduct-types

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and apologies for taking so long! I have a couple of requests on naming and good-practice definitions.

src/foundation/functoriality-coproduct-types.lagda.md Outdated Show resolved Hide resolved
src/foundation/functoriality-coproduct-types.lagda.md Outdated Show resolved Hide resolved
src/univalent-combinatorics/coproduct-types.lagda.md Outdated Show resolved Hide resolved
src/univalent-combinatorics/coproduct-types.lagda.md Outdated Show resolved Hide resolved
@morphismz
Copy link
Contributor Author

Hey @fredrik-bakke No worries for the delay, and sorry for the delay on my end :). I'll implement these changes this weekend.

@VojtechStep
Copy link
Collaborator

@morphismz I'm marking this one as a draft for now, feel free to get back to it when you have time

@VojtechStep VojtechStep marked this pull request as draft October 9, 2024 12:35
@fredrik-bakke
Copy link
Collaborator

I'm picking up this PR so it can be merged.

@fredrik-bakke fredrik-bakke self-assigned this Feb 11, 2025
@fredrik-bakke fredrik-bakke marked this pull request as ready for review February 11, 2025 14:07
@fredrik-bakke fredrik-bakke enabled auto-merge (squash) February 11, 2025 14:08
@fredrik-bakke fredrik-bakke merged commit 8855b0b into UniMath:master Feb 11, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants