-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor coproduct equivalences #1137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, and apologies for taking so long! I have a couple of requests on naming and good-practice definitions.
Hey @fredrik-bakke No worries for the delay, and sorry for the delay on my end :). I'll implement these changes this weekend. |
@morphismz I'm marking this one as a draft for now, feel free to get back to it when you have time |
I'm picking up this PR so it can be merged. |
Refactors some equivalences related to coproducs and adds one new definition.
removes the abstract block around
is-equiv-coproduct
infoundation.functorality-coproduct-types
, thus allowingmap-inv-equiv (equiv-coproduct e e')
to compute tomap-coproduct (map-inv-equiv e) (map-inv-equiv e')
. We keep abstract blocks around the proof that the inverse map is a section and retractioncomputes the underlying map of the equivalence
Fin-add-ℕ
inunivalent-combinatorics.coproduct-types