Issue #1898: Prevent NREs when adding new Texture Page Items or Embedded textures #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g new Texture Page Items or new Embedded Textures. Closes issue UnderminersTeam#1898
colinator27
requested changes
Aug 30, 2024
colinator27
approved these changes
Aug 30, 2024
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
requested changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent NREs when adding new Texture Page Items or Embedded textures by adding more null checks. Closes issue #1898
Description
As described in issue #1898, attempting to add new Texture Page Items or Embedded Textures results in Null Reference Exceptions being thrown. This MR attempts to mitigate those by adding more null value checks.
Caveats
I didn't immediately see any tests that covered these areas. If I'm missing tests that I should have added, please let me know
Notes
I'm not sure if there are any other NRE's that might be lying about. These only seem to fix the ones that I came across personally