Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to setup .NET 8 #1891

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update workflows to setup .NET 8 #1891

merged 1 commit into from
Aug 26, 2024

Conversation

colinator27
Copy link
Member

Description

We already updated to .NET 8, but the GitHub Actions workflows still set up .NET 6. This updates them.

Caveats

Something may break in the build process, but unlikely.

@Miepee
Copy link
Contributor

Miepee commented Aug 26, 2024

Why did this not fail CI before?

@colinator27
Copy link
Member Author

Why did this not fail CI before?

I think .NET 8 is included by default on the GitHub-hosted runners, so it probably "just worked" by coincidence.

@Miepee
Copy link
Contributor

Miepee commented Aug 26, 2024

then we may want to completely remove the wirth in the future maybe

@Miepee Miepee merged commit cdde573 into master Aug 26, 2024
5 checks passed
@colinator27 colinator27 deleted the net8_workflows branch August 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants