Fix Branch being overwritten less precisely #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertaleModTool into lts-differentiation
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Tested on a wide range of GameMaker versions, seems to be pretty stable. |
colinator27
previously requested changes
Aug 17, 2024
Miepee
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method TestForCommonGMSVersions estimates the version of a WAD based on which chunks are present. This is invoked twice: once at the start of deserialization, and once while parsing the GEN8 (General Info) chunk. The second case is... actually, it's completely redundant, so this PR removes it. This fixes the identification of non-LTS 2023.1 in TGIN and therefore closes #1873.
Caveats
N/A
Notes
N/A