Add NXTALE fixes for Xbox version and gamepad #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Aug 17, 2024
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
| { | ||
| i = 0 | ||
| while (i < gamepad_get_device_count())"); | ||
| ReplaceTextInGML("gml_Object_obj_time_Create_0", @" |
There was a problem hiding this comment.
Not very sure what this has to do with that. The intent is to make the game not pretend a gamepad is there on PC
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
| ScriptMessage(@"NXTALE Enabler by Kneesnap | ||
| Xbox and gamepad fixes by Dobby233Liu | ||
|
|
||
| NOTE: You're not done yet! |
There was a problem hiding this comment.
any reason we cant do this automatically?
There was a problem hiding this comment.
I just prepared the files. In case we figure this out, I think we should ask the user if they would like that first.
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
Miepee
reviewed
Aug 18, 2024
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
Miepee
reviewed
Aug 22, 2024
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
| to the folder you will save this data file to. | ||
| Then use a GMS2 2.2.2-2.2.5 runner to run Undertale. | ||
|
|
||
| Due to button constant changes, you might want to reset |
There was a problem hiding this comment.
this sounds less confusing IMO
Suggested change
| Due to button constant changes, you might want to reset | |
| Due to controller changes, you might want to reset |
Miepee
reviewed
Aug 23, 2024
UndertaleModTool/Scripts/Builtin Scripts/RunSwitchAndXboxOnPC.csx
Outdated
Show resolved
Hide resolved
Miepee
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates RunSwitchOnPC.csx (now RunSwitchAndXboxOnPC.csx)
Caveats
No Underanalyzer support
Notes