Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRE when trying to export rooms as PNG #1543

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Fix NRE when trying to export rooms as PNG #1543

merged 4 commits into from
Dec 21, 2023

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Nov 17, 2023

Description

Fixes a Null Reference Exception when trying to export rooms as PNG on GMS2 games.

Notes

Fixes #1430

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Download the artifacts for this pull request here:

GUI:

CLI:

@colinator27 colinator27 merged commit 6324f2a into UnderminersTeam:master Dec 21, 2023
5 checks passed
stuttermess added a commit to stuttermess/UndertaleModTool that referenced this pull request Dec 23, 2023
@stuttermess
Squashed commit of the following:
8799d49 
commit 34bebb6
Merge: 30f63af fd59d05
Author: colinator27 <[email protected]>
Date:   Fri Dec 22 10:50:40 2023 -0500

    Merge pull request UnderminersTeam#1519 from Miepee/o

    Revise UTSound and UTAudioGruop

commit 30f63af
Merge: e2cbf65 737b507
Author: colinator27 <[email protected]>
Date:   Fri Dec 22 10:44:56 2023 -0500

    Merge pull request UnderminersTeam#1577 from VladiStep/patch-1

    A fix of "ExportAllStrings.csx".

commit e2cbf65
Merge: 0ad6b32 21f05e9
Author: colinator27 <[email protected]>
Date:   Fri Dec 22 10:44:41 2023 -0500

    Merge pull request UnderminersTeam#1527 from Miepee/backslahes

    Slightly clean up ExportAllSounds

commit 0ad6b32
Merge: 076d857 d732f0f
Author: colinator27 <[email protected]>
Date:   Fri Dec 22 10:44:25 2023 -0500

    Merge pull request UnderminersTeam#1530 from Miepee/externalizeOggs

    Slightly clean up externalizeAllOGGs

commit 737b507
Author: Vladislav Stepanov <[email protected]>
Date:   Fri Dec 22 15:25:21 2023 +0300

    Fix UnderminersTeam#1572.

commit 076d857
Merge: 2fd7fd0 b9adf71
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:32:12 2023 -0500

    Merge pull request UnderminersTeam#1515 from Miepee/unit-test

    Add proper unit testing project

commit 2fd7fd0
Merge: 4bfec98 57d4d92
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:30:47 2023 -0500

    Merge pull request UnderminersTeam#1532 from Miepee/stringsbetter

    Remove windows requirement from exportStringsBetter

commit 4bfec98
Merge: 6201498 9e4a593
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:30:19 2023 -0500

    Merge pull request UnderminersTeam#1539 from Miepee/dunno-yet

    Clean up usings

commit 6201498
Merge: d43e97a dde90ad
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:29:35 2023 -0500

    Merge pull request UnderminersTeam#1540 from Miepee/removeassemblyinfo

    Remove obsolete configuration tools

commit d43e97a
Merge: 423b041 62e1dee
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:28:51 2023 -0500

    Merge pull request UnderminersTeam#1541 from Miepee/no-test

    Remove "Test" project

commit 423b041
Merge: 6324f2a 0299d79
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:28:12 2023 -0500

    Merge pull request UnderminersTeam#1542 from Miepee/lo

    Make clear that ttffonts is only for UT

commit 6324f2a
Merge: c8d233b 2eff692
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:27:38 2023 -0500

    Merge pull request UnderminersTeam#1543 from Miepee/some-issue

    Fix NRE when trying to export rooms as PNG

commit c8d233b
Merge: b4a81c8 d4cab35
Author: colinator27 <[email protected]>
Date:   Thu Dec 21 15:27:14 2023 -0500

    Merge pull request UnderminersTeam#1552 from VladiStep/codePastingFix

    A fix of the code editor crash.

commit 21f05e9
Author: Miepee <[email protected]>
Date:   Thu Dec 21 17:47:54 2023 +0100

    Apply suggestions from code review

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit 2eff692
Author: Miepee <[email protected]>
Date:   Thu Dec 21 17:03:32 2023 +0100

    use proper null check

commit f561c7f
Author: Miepee <[email protected]>
Date:   Thu Dec 21 17:02:32 2023 +0100

    Make slight optimization.

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit 93f1ad8
Author: Miepee <[email protected]>
Date:   Thu Dec 21 13:06:57 2023 +0100

    Update UndertaleRoomRenderer.xaml.cs

commit 16433fa
Author: Miepee <[email protected]>
Date:   Fri Nov 17 15:19:42 2023 +0100

    Fix NRE when trying to export rooms as PNG

commit d7aada8
Author: Miepee <[email protected]>
Date:   Thu Dec 21 12:47:59 2023 +0100

    Remove extra whitespace

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit 0299d79
Author: Miepee <[email protected]>
Date:   Thu Dec 21 12:46:13 2023 +0100

    Don't check for null Data

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit b4a81c8
Merge: 2f0e66e 4063ddb
Author: colinator27 <[email protected]>
Date:   Wed Dec 13 17:14:52 2023 -0500

    Merge pull request UnderminersTeam#1550 from Jacky720/version-check-fix

    More robust GMS 2.2.2.302 and PSEM checks

commit 4063ddb
Author: Jacky720 <[email protected]>
Date:   Wed Dec 13 17:05:50 2023 -0500

    Documentation TODOs, other minor changes

commit 2f0e66e
Merge: 64b52a6 1082f71
Author: colinator27 <[email protected]>
Date:   Sun Dec 10 10:39:43 2023 -0500

    Merge pull request UnderminersTeam#1559 from Miepee/setter

    Change some lists to have a public setter

commit 1082f71
Author: Miepee <[email protected]>
Date:   Wed Dec 6 11:31:26 2023 +0100

    Change some lists to have a public setter

commit 7eb625b
Author: Jacky720 <[email protected]>
Date:   Tue Dec 5 21:19:46 2023 -0500

    PSEM fixes

commit 57491bf
Author: Jacky720 <[email protected]>
Date:   Tue Dec 5 21:17:19 2023 -0500

    Invert and simplify some version detection

commit d4cab35
Author: VladiStep <[email protected]>
Date:   Mon Nov 27 18:06:35 2023 +0300

    Fix UnderminersTeam#1054.

commit 9c89907
Author: Jacky720 <[email protected]>
Date:   Sat Nov 25 13:53:05 2023 -0500

    Move 2.2.2.302 check to UndertaleChunks

commit 64b52a6
Merge: c37fbb5 96f4df6
Author: colinator27 <[email protected]>
Date:   Sun Nov 19 00:14:19 2023 -0500

    Merge pull request UnderminersTeam#1546 from Yule42/master

    Update README.md

commit 96f4df6
Author: Sophie <[email protected]>
Date:   Sat Nov 18 21:00:58 2023 -0800

    Fix the added image in README.md

commit 4592e3b
Author: Sophie <[email protected]>
Date:   Sat Nov 18 20:55:47 2023 -0800

    Update README.md

commit 62d635a
Author: Miepee <[email protected]>
Date:   Fri Nov 17 13:13:17 2023 +0100

    Make clear that ttffonts is only for UT

commit c37fbb5
Merge: ca56699 2042bfe
Author: colinator27 <[email protected]>
Date:   Fri Nov 17 00:00:29 2023 -0500

    Merge pull request UnderminersTeam#1516 from Miepee/ide-warnings

    Apply some ide warnings

commit ca56699
Merge: a29aa95 5c339d0
Author: colinator27 <[email protected]>
Date:   Fri Nov 17 00:00:17 2023 -0500

    Merge pull request UnderminersTeam#1517 from Miepee/fsn

    move iscriptinterface to filescoped namespace

commit a29aa95
Merge: a8ae767 b8603b4
Author: colinator27 <[email protected]>
Date:   Fri Nov 17 00:00:09 2023 -0500

    Merge pull request UnderminersTeam#1522 from VladiStep/lengthWarningImprovement

    The improved file length warning.

commit a8ae767
Merge: 64527e5 2ebb5b3
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:37 2023 -0500

    Merge pull request UnderminersTeam#1526 from Jacky720/assetlayerfix

    Create ParticleSystems list on asset layers

commit 64527e5
Merge: 88ef035 f12fccc
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:26 2023 -0500

    Merge pull request UnderminersTeam#1528 from Miepee/allstrings

    Redo ExportAllStrings

commit 88ef035
Merge: 47aef7a cf0c6e9
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:21 2023 -0500

    Merge pull request UnderminersTeam#1529 from Miepee/autobackup

    *Slightly* clean up AutoBackup

commit 47aef7a
Merge: 838a1dd 4483df5
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:15 2023 -0500

    Merge pull request UnderminersTeam#1533 from Miepee/importTilesets

    Make importAllTilesets work on unix

commit 838a1dd
Merge: 681259b e8ac03a
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:07 2023 -0500

    Merge pull request UnderminersTeam#1534 from Miepee/imallstrings

    Slightly clean up ImportAllStrings

commit 681259b
Merge: f721f47 98547a8
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:59:01 2023 -0500

    Merge pull request UnderminersTeam#1535 from Miepee/embeddedtexturesx

    Make Import AllEmbeddedTextures work on Unix

commit f721f47
Merge: fc29c73 41abe50
Author: colinator27 <[email protected]>
Date:   Thu Nov 16 23:58:53 2023 -0500

    Merge pull request UnderminersTeam#1536 from Miepee/libYYCCheck

    CLI: do YYC check before accessing CODE chunk

commit 62e1dee
Author: Miepee <[email protected]>
Date:   Thu Nov 16 00:19:46 2023 +0100

    Remove "Test" project

commit dde90ad
Author: Miepee <[email protected]>
Date:   Thu Nov 16 00:17:01 2023 +0100

    Remove obsolete configuration tools

commit 9e4a593
Author: Miepee <[email protected]>
Date:   Wed Nov 15 23:52:00 2023 +0100

    Clean up usings

commit 41abe50
Author: Miepee <[email protected]>
Date:   Wed Nov 15 17:22:36 2023 +0100

    CLI: do YYC check before accessing CODE chunk

commit 98547a8
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:47:01 2023 +0100

    Make Import AllEmbeddedTextures work on Unix

commit e8ac03a
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:44:02 2023 +0100

    Slightly clean up ImportAllStrings

commit 4483df5
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:37:47 2023 +0100

    Make importAllTilesets work on unix

commit 57d4d92
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:35:47 2023 +0100

    Remove windows requirement from exportStringsBetter

commit d732f0f
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:17:45 2023 +0100

    Slightly clean up externalizeAllOGGs

commit 704d7e0
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:13:12 2023 +0100

    fix typo

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit cf0c6e9
Author: Miepee <[email protected]>
Date:   Wed Nov 15 14:06:56 2023 +0100

    *Slightly* clean up AutoBackup

commit f12fccc
Author: Miepee <[email protected]>
Date:   Wed Nov 15 13:58:41 2023 +0100

    Redo ExportAllStrings

commit ccd6814
Author: Miepee <[email protected]>
Date:   Wed Nov 15 13:55:01 2023 +0100

    Slightly clean up ExportAllSounds

commit 2ebb5b3
Author: Jacky720 <[email protected]>
Date:   Tue Nov 14 21:13:06 2023 -0500

    Create ParticleSystems list on asset layers

commit b8603b4
Author: VladiStep <[email protected]>
Date:   Tue Nov 14 22:55:08 2023 +0300

    Fix UnderminersTeam#1521.

commit fd59d05
Author: Miepee <[email protected]>
Date:   Tue Nov 14 18:01:43 2023 +0100

    Revise more documentation for UTSound

commit fc29c73
Merge: c99e556 bba5f9f
Author: colinator27 <[email protected]>
Date:   Sun Nov 12 12:58:16 2023 -0500

    Merge pull request UnderminersTeam#1389 from Dobby233Liu/Dobby233Liu-igms2fd-1

    Fix igms2fd to work with the new changes

commit c99e556
Merge: 99381fd e78ca8b
Author: colinator27 <[email protected]>
Date:   Sun Nov 12 12:57:25 2023 -0500

    Merge pull request UnderminersTeam#1455 from Jacky720/switchcaseplumbing

    Prevent blocks from being requeued in switch decompilation

commit 99381fd
Merge: 1beac06 dfae57c
Author: colinator27 <[email protected]>
Date:   Sun Nov 12 12:55:28 2023 -0500

    Merge pull request UnderminersTeam#1474 from VladiStep/tabsSwitchFix

    Tab selection bug fixes.

commit 2042bfe
Author: Miepee <[email protected]>
Date:   Sun Nov 12 13:36:30 2023 +0100

    Apply formatting suggestion from Vlad

    Co-authored-by: Vladislav Stepanov <[email protected]>

commit bba5f9f
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 19:06:51 2023 +0800

    != null -> is not null

commit 253779d
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 12:17:46 2023 +0800

    Istg

commit 85dcda3
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 12:17:05 2023 +0800

    Fix crash when used in pre-bytecode 17 games

commit ab133aa
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 11:46:34 2023 +0800

    Adapt for 2023.8

commit ce72608
Merge: d800f12 1beac06
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 11:39:51 2023 +0800

    Merge branch 'krzys-h:master' into Dobby233Liu-igms2fd-1

commit d800f12
Author: Liu Wenyuan <[email protected]>
Date:   Sun Nov 12 10:46:40 2023 +0800

    Change line ending to lf

commit 5c339d0
Author: Miepee <[email protected]>
Date:   Sun Nov 12 01:34:58 2023 +0100

    move iscriptinterface to filescoped namespace

commit b9adf71
Author: Miepee <[email protected]>
Date:   Sun Nov 12 00:58:30 2023 +0100

    Add proper unit testing project

commit 21a1d74
Author: Miepee <[email protected]>
Date:   Sun Nov 12 01:22:50 2023 +0100

    Apply some ide warnings

commit dfae57c
Author: VladiStep <[email protected]>
Date:   Tue Sep 19 16:48:49 2023 +0300

    Fix tab swapping to the left

commit a3b484f
Author: VladiStep <[email protected]>
Date:   Wed Sep 13 14:34:27 2023 +0300

    Fix UnderminersTeam#1473.

commit 0893b98
Author: VladiStep <[email protected]>
Date:   Wed Sep 13 14:29:44 2023 +0300

    Fix UnderminersTeam#1472.

commit e78ca8b
Author: Jacky720 <[email protected]>
Date:   Sat Aug 5 16:12:09 2023 -0400

    Add a HashSet to reduce switch memory consumption

commit 008425a
Author: Liu Wenyuan <[email protected]>
Date:   Sat May 20 22:09:19 2023 +0800

    Fix igms2fd to work with the new changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladiStep VladiStep VladiStep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExportAllRoomsToPng.csx fails with a "Value cannot be null" error
3 participants
@Miepee @VladiStep @colinator27