Add LineHeight as a 2023.6 font attribute. #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the new LineHeight value included in GM2023.6 fonts with appropriate version detection. Also, fixes an apparent typo in IsVersionAtLeastConverter that would set
buildto what should have beenrelease, overriding the correctbuild. It likely didn't affect anything since most version checks aren't that precise, but better safe than sorry.Caveats
Has not been extensively tested. The original reporter of #1453 claims the same error occurs with GM2023.4, which I could not reproduce.
The LineHeight value has remarks on being added with 2023.6, but not a summary because I'm not 100% sure how it interacts with games. It's probably in the GameMaker changelog...
Notes
N/A