Merge pull request #1887 from UnderminersTeam/fix-string-bounds-checks

Fix string reading bounds checks
UnderminersTeam · Aug 24, 2024 · fe1b45b · fe1b45b
2 parents 6f470f8 + 4d2ef0b
commit fe1b45b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/UndertaleModLib/Util/BufferBinaryReader.cs b/UndertaleModLib/Util/BufferBinaryReader.cs
@@ -286,7 +286,7 @@ public string ReadGMString()
 
             if (length < 0)
                 throw new IOException("Invalid string length");
-            if (chunkBuffer.Position + length + 1 >= _length)
+            if (chunkBuffer.Position + length + 1 > _length)
                 throw new IOException("Reading out of chunk bounds");
 
             string res;

diff --git a/UndertaleModLib/Util/FileBinaryReader.cs b/UndertaleModLib/Util/FileBinaryReader.cs
@@ -214,7 +214,7 @@ public string ReadGMString()
 
             if (length < 0)
                 throw new IOException("Invalid string length");
-            if (Stream.Position + length + 1 >= _length)
+            if (Stream.Position + length + 1 > _length)
                 throw new IOException("Reading out of bounds");
 
             string res;