Skip to content

Fix string reading bounds checks #1043

Fix string reading bounds checks

Fix string reading bounds checks #1043

Triggered via pull request August 24, 2024 19:21
Status Success
Total duration 2m 59s
Artifacts 5

publish_pr.yml

on: pull_request
Matrix: build_gui
Matrix: publish_cli
Fit to window
Zoom out
Zoom in

Annotations

88 warnings
publish_cli (ubuntu-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
publish_cli (ubuntu-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
publish_cli (ubuntu-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (ubuntu-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
publish_cli (macOS-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
publish_cli (macOS-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (macOS-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
publish_cli (windows-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/DumpOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L24
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/LoadOptions.cs#L29
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/CommandOptions/ReplaceOptions.cs#L19
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
publish_cli (windows-latest, Debug, false): UndertaleModCli/Program.cs#L734
XML comment has cref attribute 'code' that could not be resolved
build_gui (windows-latest, Debug, false, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
build_gui (windows-latest, Debug, false, false): UndertaleModTool/MessageBoxExtensions.cs#L45
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
build_gui (windows-latest, Debug, false, false): UndertaleModTool/MainWindow.xaml.cs#L3096
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/ScriptingFunctions.cs#L32
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Windows/TextInput.cs#L71
This call site is reachable on all platforms. 'Icon' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap.GetHbitmap()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleShaderEditor.xaml.cs#L48
This call site is reachable on all platforms. 'TextEditor.Text' is only supported on: 'Windows' 7.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
build_gui (windows-latest, Debug, false, false): UndertaleModTool/MessageBoxExtensions.cs#L45
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
build_gui (windows-latest, Debug, false, false): UndertaleModTool/MainWindow.xaml.cs#L3096
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/ScriptingFunctions.cs#L32
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Windows/TextInput.cs#L71
This call site is reachable on all platforms. 'Icon' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap.GetHbitmap()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, false): UndertaleModTool/Editors/UndertaleShaderEditor.xaml.cs#L67
This call site is reachable on all platforms. 'TextEditor.Text' is only supported on: 'Windows' 7.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
build_gui (windows-latest, Debug, false, true): UndertaleModTool/MessageBoxExtensions.cs#L45
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
build_gui (windows-latest, Debug, false, true): UndertaleModTool/MainWindow.xaml.cs#L3096
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/ScriptingFunctions.cs#L32
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Windows/TextInput.cs#L71
This call site is reachable on all platforms. 'Icon' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleShaderEditor.xaml.cs#L48
This call site is reachable on all platforms. 'TextEditor.Text' is only supported on: 'Windows' 7.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleShaderEditor.xaml.cs#L67
This call site is reachable on all platforms. 'TextEditor.Text' is only supported on: 'Windows' 7.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModLib/Scripting/IScriptInterface.cs#L316
XML comment has cref attribute 'isFinishedMessageEnabled' that could not be resolved
build_gui (windows-latest, Debug, false, true): UndertaleModTool/MessageBoxExtensions.cs#L45
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
build_gui (windows-latest, Debug, false, true): UndertaleModTool/MainWindow.xaml.cs#L3096
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/ScriptingFunctions.cs#L32
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Windows/TextInput.cs#L71
This call site is reachable on all platforms. 'Icon' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap.GetHbitmap()' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs#L2537
This call site is reachable on all platforms. 'Bitmap' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
build_gui (windows-latest, Debug, false, true): UndertaleModTool/Editors/UndertaleShaderEditor.xaml.cs#L48
This call site is reachable on all platforms. 'TextEditor.Text' is only supported on: 'Windows' 7.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)

Artifacts

Produced during runtime
Name Size
CLI-macOS-latest-isBundled-false
23.9 MB
CLI-ubuntu-latest-isBundled-false
22.2 MB
CLI-windows-latest-isBundled-false
17.4 MB
GUI-windows-latest-isBundled-false-isSingleFile-false
35 MB
GUI-windows-latest-isBundled-false-isSingleFile-true
34.9 MB