Fix unused parameters being passed to pie chart

[cvanelteren]

Addresses #259

Will need to check this later today or tomorrow as I don't have time to check this now.

[cvanelteren]

TODO: Still needs a test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[cvanelteren]

Not entirely sure why for dataframes the code is forwarding the legend_kw or colorbar_kw but removing this will cause other tests to fail. What remains sure is that for pie charts these need not be forwarded; so the major contribution is to eliminate those from kwargs prior to plotting with matplotlib's pie function.

[Copilot]

Pull Request Overview

This PR ensures that unused legend and colorbar parameters are not passed to pie charts (fixing #259) and adds a test to verify DataFrame index labels appear correctly on pie slices.

• Extract legend and colorbar label values early in _parse_1d_format
• Pop legend_kw and colorbar_kw in pie before calling the native implementation
• Add a test case for labeled DataFrame input to pie
• Include an example script demonstrating pie usage with DataFrames

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
ultraplot/tests/test_plot.py	Add test_pie_labeled_series_in_dataframes to cover #259 edge case
ultraplot/axes/plot.py	Extract and remove unused legend/colorbar kwargs in parser and pie
test.py	Add demo script for pie-chart with DataFrame indices

Comments suppressed due to low confidence (3)

ultraplot/axes/plot.py:2291

• The variable name colorbar_kw_labels is misleading since it holds the 'values' popped from colorbar_kw. Consider renaming it to colorbar_kw_values to match its purpose and the downstream parameter name.

colorbar_kw_labels = _not_none(

test.py:31

• The call to uplt.subplot() likely should be uplt.subplots() to match the API used elsewhere (subplots returns both figure and axes). This typo can cause a runtime error.

fig, ax = uplt.subplot()

test.py:1

• [nitpick] This demo script in the project root (test.py) could be moved to an examples/ directory to avoid confusion with actual test files and keep the repo organized.

# %%