-
Notifications
You must be signed in to change notification settings - Fork 12
Hotfix GeoAxes indicate zoom. #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the z-order of inset zoom indicators on geographic axes so that connectors render above the axes, and it adds an image comparison test to verify basic zoom behavior.
- Adjust z-order for inset zoom connectors in
__format_inset
- Import and apply the
@override
decorator toindicate_inset_zoom
- Add a new
pytest.mark.mpl_image_compare
test for geographic inset zoom
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ultraplot/axes/base.py | Set connector z-order above the axes and import override |
ultraplot/tests/test_geographic.py | Add test_inset_axes_geographic to cover geographic zoom inset |
Comments suppressed due to low confidence (1)
ultraplot/tests/test_geographic.py:744
- [nitpick] The image-comparison test verifies visual output but doesn’t explicitly check connector or rectangle z-order values. Consider adding a lightweight unit test to assert that the z-order of connectors (and the rectangle) equals
ax.get_zorder() + 1
to guard against regressions.
@pytest.mark.mpl_image_compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
I may have to mock a change as I committed before black go take hold. Otherwise there are big changes here. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Hotfix GeoAxes indicate zoom. This PR ensures that the zorder is above that of the axes. Addresses #245.