Skip to content

Hotfix GeoAxes indicate zoom. #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

cvanelteren
Copy link
Contributor

@cvanelteren cvanelteren commented Jun 5, 2025

Hotfix GeoAxes indicate zoom. This PR ensures that the zorder is above that of the axes. Addresses #245.

@cvanelteren cvanelteren requested review from beckermr and Copilot and removed request for beckermr June 5, 2025 09:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the z-order of inset zoom indicators on geographic axes so that connectors render above the axes, and it adds an image comparison test to verify basic zoom behavior.

  • Adjust z-order for inset zoom connectors in __format_inset
  • Import and apply the @override decorator to indicate_inset_zoom
  • Add a new pytest.mark.mpl_image_compare test for geographic inset zoom

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ultraplot/axes/base.py Set connector z-order above the axes and import override
ultraplot/tests/test_geographic.py Add test_inset_axes_geographic to cover geographic zoom inset
Comments suppressed due to low confidence (1)

ultraplot/tests/test_geographic.py:744

  • [nitpick] The image-comparison test verifies visual output but doesn’t explicitly check connector or rectangle z-order values. Consider adding a lightweight unit test to assert that the z-order of connectors (and the rectangle) equals ax.get_zorder() + 1 to guard against regressions.
@pytest.mark.mpl_image_compare

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ultraplot/axes/base.py 62.50% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@cvanelteren cvanelteren requested a review from beckermr June 5, 2025 09:54
@cvanelteren
Copy link
Contributor Author

I may have to mock a change as I committed before black go take hold. Otherwise there are big changes here.

@beckermr
Copy link
Collaborator

beckermr commented Jun 5, 2025

pre-commit.ci autofix

@beckermr beckermr enabled auto-merge (squash) June 5, 2025 10:17
@cvanelteren cvanelteren disabled auto-merge June 5, 2025 14:05
@cvanelteren cvanelteren closed this Jun 5, 2025
@cvanelteren cvanelteren reopened this Jun 5, 2025
@cvanelteren cvanelteren enabled auto-merge (squash) June 5, 2025 14:06
@beckermr beckermr disabled auto-merge June 5, 2025 14:35
@beckermr beckermr merged commit 689f601 into Ultraplot:main Jun 5, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants