Deprecate basemap #243
Merged
Deprecate basemap #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
beckermr
requested changes
Jun 1, 2025
cvanelteren
force-pushed
the
deprecate_basemap
branch
from
98a1e75 to
9a89c30
Compare
beckermr
approved these changes
Jun 1, 2025
cvanelteren
force-pushed
the
deprecate_basemap
branch
from
9a89c30 to
71371e2
Compare
cvanelteren
added a commit
to cvanelteren/ultraplot
that referenced
this pull request
Jun 2, 2025
* Deprecate basemap. Basemap will be deprecated in the next major release (v2.0). See Ultraplot#243 for context.
beckermr
pushed a commit
that referenced
this pull request
Jun 3, 2025
* simplified logic and basing reference on original grid * rm print statements * spelling * Update ultraplot/figure.py Co-authored-by: Copilot <[email protected]> * do more comprehensive checking * rm debug * add some reasoning * fixed * add a stale check * compound tests and check for the failure * fixed missing functions in grid * need to fix test * update calls * update tests * formatting restored to defaults * don't adjust labels when not sharing * tests pass -- some expected failures * rm debug statements * fix test * added tests * updated test to check for sharing of panels * update test * update test * Update ultraplot/tests/test_geographic.py Co-authored-by: Copilot <[email protected]> * rm unnecessary funcs * Deprecate basemap (#243) * Deprecate basemap. Basemap will be deprecated in the next major release (v2.0). See #243 for context. * Hotfix get_border_axes (#236) * simplified logic and basing reference on original grid * rm print statements * spelling * Update ultraplot/figure.py Co-authored-by: Copilot <[email protected]> * do more comprehensive checking * rm debug * add some reasoning * fixed * add a stale check * compound tests and check for the failure * update calls * update tests * formatting restored to defaults * don't adjust labels when not sharing * tests pass -- some expected failures * rm debug statements * fix test * Update ultraplot/tests/test_geographic.py Co-authored-by: Copilot <[email protected]> * Update ultraplot/figure.py Co-authored-by: Copilot <[email protected]> * Update ultraplot/axes/geo.py Co-authored-by: Copilot <[email protected]> * Revert changes * rm duplicate * fixes --------- Co-authored-by: Copilot <[email protected]> * refactor panel_group_member * mv logic to base * mv to the correct spot --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce a deprecation warning for basemap. The rationale behind deprecation is as follows: basemap was deprecated in the past, but it seemed like development was picking up steam again. It has been a few months since I submitted a few PRs that would update basemap with modern tooling (in particular numpy, see matplotlib/basemap#604, matplotlib/basemap#623, matplotlib/basemap#622). Not sure what the status is currently but little activity has been seen on that repo for a while. Furthermore, cartopy has more powerful features with good matplotlib support. Lastly, it would streamline our development as we only have to focus on a singular backend and
geo.pyneeds a refactor in my opinion.I open this PR up for community members to chip in, but I don't see a good reason to not do this.