Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no interactions to list of output args #114

Merged
merged 2 commits into from
May 20, 2023
Merged

Add no interactions to list of output args #114

merged 2 commits into from
May 20, 2023

Conversation

qashlan
Copy link
Contributor

@qashlan qashlan commented May 19, 2023

Add --noninteractive
issue #113

Ullaakut
Ullaakut requested changes May 20, 2023
View reviewed changes
Copy link
Owner

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @qashlan ! Thanks for your PR. My only suggestion is to keep the function name consistent with the flag name to make sure people find it with auto completion as they would expect.

Besides that, LGTM :) Thanks again!

optionsOutput.go Outdated Show resolved Hide resolved
optionsOutput_test.go Outdated Show resolved Hide resolved
@Ullaakut Ullaakut added the enhancement New feature or request label May 20, 2023
@qashlan qashlan requested a review from Ullaakut May 20, 2023 08:01
Ullaakut
Ullaakut approved these changes May 20, 2023
View reviewed changes
Copy link
Owner

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Have a great weekend :)

@Ullaakut Ullaakut merged commit 89031ae into Ullaakut:master May 20, 2023
@qashlan qashlan deleted the Add_noninteractive_to_output_options branch May 20, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

Assignees

@qashlan qashlan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qashlan @Ullaakut